[Opengeoscience-developers] [geoweb] Setup dev build so only one list of source files is need (#88)

[Chris Harris]

Looks good,

88-enhance-run-from-source-config is ready to go into master.

Chris

On Fri, Aug 9, 2013 at 10:52 AM, Ben Burnett <benjam.arlyn at gmail.com> wrote:

> Oops, I just added it.
>
> Best,
> Ben
>
>
> On Fri, Aug 9, 2013 at 8:27 AM, Chris Harris <chris.harris at kitware.com>wrote:
>
>> Sounds good ...
>>
>>
>> On Fri, Aug 9, 2013 at 8:18 AM, Aashish Chaudhary <
>> aashish.chaudhary at kitware.com> wrote:
>>
>>>
>>>
>>>
>>> On Fri, Aug 9, 2013 at 8:05 AM, Chris Harris <chris.harris at kitware.com>wrote:
>>>
>>>> Hi Ben,
>>>>
>>>> Nice idea, but looks like you missed adding geoweb.min.js.in ?
>>>>
>>>> Aashish, Was there any reason JS_UGLIFY_FILES and JS_LINT_FILES where
>>>> separate lists?
>>>>
>>>
>>> The reason is not valid anymore in some ways. For uglify we have to
>>> follow a strict order but for lint that's not the case.
>>>
>>> I agree that since the code is somewhat stable we can just have one.
>>>
>>> - Aashish
>>>
>>>
>>>>
>>>> Chris
>>>>
>>>> On Thu, Aug 8, 2013 at 7:24 PM, benbu <notifications at github.com> wrote:
>>>>
>>>>> Added in branch 88-enhance-run-from-source-config
>>>>>
>>>>> This makes it so you only need to add new files to a single list
>>>>> in the CMakeLists.txt file. The source based geoweb.min.js is now
>>>>> autogenerated using the JS_UGLIFY_FILES list. Additionally,
>>>>> JS_LINT_FILES originates from JS_UGLIFY_FILES now, leaving a single
>>>>> list of source files in CMakeLists.txt
>>>>>
>>>>> @cjh1 <https://github.com/cjh1> can you review this and get it into
>>>>> master?
>>>>>
>>>>> —
>>>>> Reply to this email directly or view it on GitHub<https://github.com/OpenGeoscience/geoweb/issues/88#issuecomment-22365777>
>>>>> .
>>>>>
>>>>
>>>>
>>>> _______________________________________________
>>>> Opengeoscience-developers mailing list
>>>> Opengeoscience-developers at public.kitware.com
>>>>
>>>> http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers
>>>>
>>>>
>>>
>>>
>>> --
>>> | Aashish Chaudhary
>>> | R&D Engineer
>>> | Kitware Inc.
>>> | www.kitware.com
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130809/e99190fb/attachment.html>