Looks good, <div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)"><br></span></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">88-enhance-run-from-source-</span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px;background-color:rgb(255,255,255)">config is ready to go into master.</span><div>
<font color="#222222" face="arial, sans-serif"><br></font></div><div><font color="#222222" face="arial, sans-serif">Chris<br></font><br><div class="gmail_quote">On Fri, Aug 9, 2013 at 10:52 AM, Ben Burnett <span dir="ltr"><<a href="mailto:benjam.arlyn@gmail.com" target="_blank">benjam.arlyn@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Oops, I just added it.<div><br></div><div>Best,</div><div>Ben</div></div><div class="HOEnZb"><div class="h5">
<div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 9, 2013 at 8:27 AM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds good ...<div><div><br><br><div class="gmail_quote">On Fri, Aug 9, 2013 at 8:18 AM, Aashish Chaudhary <span dir="ltr"><<a href="mailto:aashish.chaudhary@kitware.com" target="_blank">aashish.chaudhary@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote"><div>On Fri, Aug 9, 2013 at 8:05 AM, Chris Harris <span dir="ltr"><<a href="mailto:chris.harris@kitware.com" target="_blank">chris.harris@kitware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ben, <div><br></div><div>Nice idea, but looks like you missed adding <span style="color:rgb(34,34,34);white-space:pre-wrap"><a href="http://geoweb.min.js.in" target="_blank">geoweb.min.js.in</a> ?</span></div>
<div><span style="color:rgb(34,34,34);white-space:pre-wrap"><br></span></div><div><span style="color:rgb(34,34,34);white-space:pre-wrap">Aashish, Was there any reason </span>JS_UGLIFY_FILES and JS_LINT_FILES where separate lists?</div>
</blockquote><div><br></div></div><div>The reason is not valid anymore in some ways. For uglify we have to follow a strict order but for lint that's not the case. </div><div><br></div><div>I agree that since the code is somewhat stable we can just have one. </div>
<div><br></div><div>- Aashish</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><span><font color="#888888">
<div><br></div><div>Chris</div></font></span><div><div><div><br><div class="gmail_quote">On Thu, Aug 8, 2013 at 7:24 PM, benbu <span dir="ltr"><<a href="mailto:notifications@github.com" target="_blank">notifications@github.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p>Added in branch 88-enhance-run-from-source-config</p>
<pre><code>This makes it so you only need to add new files to a single list
in the CMakeLists.txt file. The source based geoweb.min.js is now
autogenerated using the JS_UGLIFY_FILES list. Additionally,
JS_LINT_FILES originates from JS_UGLIFY_FILES now, leaving a single
list of source files in CMakeLists.txt
</code></pre>
<p><a href="https://github.com/cjh1" target="_blank">@cjh1</a> can you review this and get it into master?</p><div><div>
<p style="font-size:small;color:#666">—<br>Reply to this email directly or <a href="https://github.com/OpenGeoscience/geoweb/issues/88#issuecomment-22365777" target="_blank">view it on GitHub</a>.<img height="1" width="1"></p>
</div></div></blockquote></div><br></div>
</div></div><br></div>_______________________________________________<br>
Opengeoscience-developers mailing list<br>
<a href="mailto:Opengeoscience-developers@public.kitware.com" target="_blank">Opengeoscience-developers@public.kitware.com</a><br>
<a href="http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers" target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/opengeoscience-developers</a><br>
<br></blockquote></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br>| Aashish Chaudhary <br>| R&D Engineer <br>| Kitware Inc. <br>| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a>
</font></span></div></div>
</blockquote></div><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>