[Opengeoscience-developers] jslint fixes

[Manas Pawar]

Hi Aashish,

Thank you for the pointers. This gives us a more defined idea of what has to be done. We will use the same flag comment that you have here. Accordingly we will update the UI directory. But to push the changes we will have to come to college. Thank you.

Regards
Manas Pawar
________________________________
From: Aashish Chaudhary [aashish.chaudhary at kitware.com]
Sent: Saturday, April 27, 2013 11:50 AM
To: Manas Pawar; Keval Sheth; Ben Burnett
Subject: jslint fixes

Hi Manas, Keval,

I pushed my fixes on your branch and merged it into master after it verified that map demo still works. Basically here is the summary of my changes:

1. I used these flags for jslint
/*jslint devel: true, forin: true, newcap: true, plusplus: true, white: true, indent: 2*/

we DONT want to use eqeq to true and then I ADDED white: true as I like spacing between ) and {

2. I fixed var declaration issues. I think I would prefer we do assignment when declaring a variable. So for example
var a = 10,
     b = 20;  // Not that I indented b right under a

3. Our headings look like this:
/**
 * @module ogs.geo
 */

4. This code was wrong:
currentElement = this

it should have been currentElement = m_node since in that block we were asking for its parent and
HTML related attributes. this would have been the map class and it does not belong to an html element.

/*jslint devel: true, forin: true, newcap: true, plusplus: true, white: true, indent: 2*/
/*global geoModule, ogs, inherit, $, HTMLCanvasElement, Image, vglModule, document*/

5. When we make changes we should make sure the demos / tests works. There were two issues that broke the code. So I fixed it.

I hope this help. I am looking forward to the UI branch.


--
| Aashish Chaudhary
| R&D Engineer
| Kitware Inc.
| www.kitware.com<http://www.kitware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/opengeoscience-developers/attachments/20130427/5b24b097/attachment.html>