<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" id="owaParaStyle"></style><style type="text/css"><!----></style>
</head>
<body fpstyle="1" ocsi="0">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hi Aashish,
<div><br>
</div>
<div>Thank you for the pointers. This gives us a more defined idea of what has to be done. We will use the same flag comment that you have here. Accordingly we will update the UI directory. But to push the changes we will have to come to college. Thank you.</div>
<div><br>
</div>
<div>Regards</div>
<div>Manas Pawar<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div id="divRpF560204" style="direction: ltr;"><font face="Tahoma" size="2" color="#000000"><b>From:</b> Aashish Chaudhary [aashish.chaudhary@kitware.com]<br>
<b>Sent:</b> Saturday, April 27, 2013 11:50 AM<br>
<b>To:</b> Manas Pawar; Keval Sheth; Ben Burnett<br>
<b>Subject:</b> jslint fixes<br>
</font><br>
</div>
<div></div>
<div>
<div dir="ltr">Hi Manas, Keval,
<div><br>
</div>
<div>I pushed my fixes on your branch and merged it into master after it verified that map demo still works. Basically here is the summary of my changes:</div>
<div><br>
</div>
<div>1. I used these flags for jslint</div>
<div>/*jslint devel: true, forin: true, newcap: true, plusplus: true, white: true, indent: 2*/</div>
<div><br>
</div>
<div>we DONT want to use eqeq to true and then I ADDED white: true as I like spacing between ) and {</div>
<div><br>
</div>
<div>2. I fixed var declaration issues. I think I would prefer we do assignment when declaring a variable. So for example</div>
<div style="">var a = 10,</div>
<div style=""> b = 20; // Not that I indented b right under a</div>
<div style=""><br>
</div>
<div style="">3. Our headings look like this: </div>
<div style="">
<div>/**</div>
<div> * @module ogs.geo</div>
<div> */</div>
<div><br>
</div>
<div style="">4. This code was wrong:</div>
<div style="">currentElement = this </div>
<div style=""><br>
</div>
<div style="">it should have been currentElement = m_node since in that block we were asking for its parent and</div>
<div style="">HTML related attributes. this would have been the map class and it does not belong to an html element. </div>
<div><br>
</div>
<div>/*jslint devel: true, forin: true, newcap: true, plusplus: true, white: true, indent: 2*/</div>
<div>/*global geoModule, ogs, inherit, $, HTMLCanvasElement, Image, vglModule, document*/</div>
<div><br>
</div>
<div style="">5. When we make changes we should make sure the demos / tests works. There were two issues that broke the code. So I fixed it. </div>
<div style=""><br>
</div>
<div style="">I hope this help. I am looking forward to the UI branch. </div>
</div>
<div style=""><br>
</div>
<div>
<div><br>
</div>
-- <br>
| Aashish Chaudhary <br>
| R&D Engineer <br>
| Kitware Inc. <br>
| <a href="http://www.kitware.com" target="_blank">www.kitware.com</a> </div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>