[ITK-users] Documentation: itk::AttributeSelectionLabelMapFilter

[Dženan Zukić]

Matt, what was the problem with this?

On Fri, Oct 14, 2016 at 9:21 AM, Chr. Rossmanith <
cr at neuro.ma.uni-heidelberg.de> wrote:

> When visiting review.source.kitware.com -> sign in -> provide github
> credentials  I find myself on a page telling me "forbidden". But without a
> gerrit user I'm stuck...Any hints? I've double checked the credentials by
> signing in into github.
>
> Christina
>
>
> On 14.10.2016 15:00, Dženan Zukić wrote:
>
> Hi Christina,
>
> gerrit is the only way to merge patches. Can you submit it as a patch to
> gerrit?
>
> Thanks,
> Dženan
>
> On Fri, Oct 14, 2016 at 8:52 AM, Chr. Rossmanith <
> cr at neuro.ma.uni-heidelberg.de> wrote:
>
>> Hi Matt,
>>
>> I've forked on github, extended the documentation and created a pull
>> request. Or is gerrit the only way to get a patch merged?
>>
>> Christina
>>
>>
>>
>> On 12.10.2016 18:03, Matt McCormick wrote:
>>
>>> Hello Christina,
>>>
>>> Good idea.
>>>
>>> To update the documentation, the class Doxygen documentation can be
>>> editted:
>>>
>>>    https://github.com/InsightSoftwareConsortium/ITK/blob/maste
>>> r/Modules/Filtering/LabelMap/include/itkAttributeSelectionL
>>> abelMapFilter.h#L27-L46
>>>
>>> and after a patch is submitted:
>>>
>>>    https://itk.org/Wiki/ITK/Git/Develop
>>>
>>> it will show up on the Doxygen web pages.
>>>
>>> Please let us know if you have any questions.
>>>
>>> Thanks,
>>> Matt
>>>
>>> On Wed, Oct 12, 2016 at 11:57 AM, Chr. Rossmanith
>>> <cr at neuro.ma.uni-heidelberg.de> wrote:
>>>
>>>> Hi,
>>>>
>>>> I think it would be helpful if the documentation of the filter would
>>>> mention
>>>> that there are two outputs, one with the surviving labels and the second
>>>> with the removed labels (the input image is the union of these images).
>>>> What
>>>> is the workflow to achieve this?
>>>>
>>>> Christina
>>>>
>>>> _____________________________________
>>>> Powered by www.kitware.com
>>>>
>>>> Visit other Kitware open-source projects at
>>>> http://www.kitware.com/opensource/opensource.html
>>>>
>>>> Kitware offers ITK Training Courses, for more information visit:
>>>> http://www.kitware.com/products/protraining.php
>>>>
>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>
>>>> Follow this link to subscribe/unsubscribe:
>>>> http://public.kitware.com/mailman/listinfo/insight-users
>>>>
>>>
>>
>> _____________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://www.kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://public.kitware.com/mailman/listinfo/insight-users
>>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-users/attachments/20161014/e3582ba6/attachment.html>