<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Matt, what was the problem with this?</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 14, 2016 at 9:21 AM, Chr. Rossmanith <span dir="ltr"><<a href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank">cr@neuro.ma.uni-heidelberg.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div bgcolor="#FFFFFF" text="#000000">
<div class="m_5631115253807949987moz-cite-prefix">When visiting <a href="http://review.source.kitware.com" target="_blank">review.source.kitware.com</a>
-> sign in -> provide github credentials I find myself on a
page telling me "forbidden". But without a gerrit user I'm
stuck...Any hints? I've double checked the credentials by signing
in into github.<br>
<br>
Christina<div><div class="h5"><br>
<br>
On 14.10.2016 15:00, Dženan Zukić wrote:<br>
</div></div></div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Hi
Christina,</div>
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br>
</div>
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">gerrit
is the only way to merge patches. Can you submit it as a patch
to gerrit?</div>
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br>
</div>
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Thanks,</div>
<div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">Dženan</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Fri, Oct 14, 2016 at 8:52 AM, Chr.
Rossmanith <span dir="ltr"><<a href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank">cr@neuro.ma.uni-heidelberg.de</a><wbr>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Matt,<br>
<br>
I've forked on github, extended the documentation and
created a pull request. Or is gerrit the only way to get a
patch merged?<br>
<br>
Christina
<div class="m_5631115253807949987HOEnZb">
<div class="m_5631115253807949987h5"><br>
<br>
<br>
On 12.10.2016 18:03, Matt McCormick wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hello Christina,<br>
<br>
Good idea.<br>
<br>
To update the documentation, the class Doxygen
documentation can be editted:<br>
<br>
<a href="https://github.com/InsightSoftwareConsortium/ITK/blob/master/Modules/Filtering/LabelMap/include/itkAttributeSelectionLabelMapFilter.h#L27-L46" rel="noreferrer" target="_blank">https://github.com/InsightSof<wbr>twareConsortium/ITK/blob/maste<wbr>r/Modules/Filtering/LabelMap/<wbr>include/itkAttributeSelectionL<wbr>abelMapFilter.h#L27-L46</a><br>
<br>
and after a patch is submitted:<br>
<br>
<a href="https://itk.org/Wiki/ITK/Git/Develop" rel="noreferrer" target="_blank">https://itk.org/Wiki/ITK/Git/<wbr>Develop</a><br>
<br>
it will show up on the Doxygen web pages.<br>
<br>
Please let us know if you have any questions.<br>
<br>
Thanks,<br>
Matt<br>
<br>
On Wed, Oct 12, 2016 at 11:57 AM, Chr. Rossmanith<br>
<<a href="mailto:cr@neuro.ma.uni-heidelberg.de" target="_blank">cr@neuro.ma.uni-heidelberg.de</a><wbr>>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi,<br>
<br>
I think it would be helpful if the documentation of
the filter would mention<br>
that there are two outputs, one with the surviving
labels and the second<br>
with the removed labels (the input image is the
union of these images). What<br>
is the workflow to achieve this?<br>
<br>
Christina<br>
<br>
______________________________<wbr>_______<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more
information visit:<br>
<a href="http://www.kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://www.kitware.com/product<wbr>s/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ
at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FA<wbr>Q</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/insight-users" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/insight-users</a><br>
</blockquote>
</blockquote>
<br>
<br>
______________________________<wbr>_______<br>
Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>
<br>
Visit other Kitware open-source projects at<br>
<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensou<wbr>rce/opensource.html</a><br>
<br>
Kitware offers ITK Training Courses, for more
information visit:<br>
<a href="http://www.kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://www.kitware.com/product<wbr>s/protraining.php</a><br>
<br>
Please keep messages on-topic and check the ITK FAQ at:<br>
<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FA<wbr>Q</a><br>
<br>
Follow this link to subscribe/unsubscribe:<br>
<a href="http://public.kitware.com/mailman/listinfo/insight-users" rel="noreferrer" target="_blank">http://public.kitware.com/mail<wbr>man/listinfo/insight-users</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<p><br>
</p>
</div></div></div>
</blockquote></div><br></div>