[Insight-users] Bugs in HistogramToImage filter and in ImageToVTKImageFilter.

[Luis Ibanez]

Hi Diego,

Thanks for pointing this out.

You are right both of them were bugs.

We just committed fixes for them in the CVS repository.

Please update your CVS checkout of ITK and let us know
if you find any other problem.


     Regards,


         Luis



-------------------------
Diego Bordegari wrote:
> === first
> 
> HistogramToEntropyImageFilter returns an image with an uninitialized
> origin and I'm not sure this can be ignored.
> The method HistogramToImageFilter::GenerateData() declares a local array
> origin[2]
> but never initializes this value. Therefore the origin of the image that
> HistogramToEntropyImageFilter generates could be garbage.
> 
> Here a snippet of the code
> HistogramToImageFilter<THistogram, TFunction>
> ::GenerateData
> {
> 
>   ...
>   double origin[ImageDimension];
>   ...
>   outputImage->SetSpacing(m_Spacing);         // set spacing
>   outputImage->SetOrigin(origin);   //   and origin ( its value is
> garbage )
>  ... 
> }
> 
> Inspired by the Registration/ImageRegistrationHistogramPlotter.cxx I
> wanted to display
> the histogram ( of a 3D registration ) with vtk but I couldn't see the
> image. 
> By 
> - initializing the origin={0}  inside the GenerateData()  
> or,
> - setting to {0} the origin of the HistogramToEntropyImageFilter's
> output image
> I finally got the histogram displayed.
> 
> ==== second
> 
> I think the class ImageToVTKImageFilter causes a memory leak at the time
> it is destroyed.
> The class destructor
> 
> template <class TInputImage>
> ImageToVTKImageFilter<TInputImage>
> ::~ImageToVTKImageFilter()
> {
> }
> is missing the line 
> 
> m_Importer->Delete() ;
> 
> for the private vtkImageImport * object.
> 
> 
> 
> -----Original Message-----
> From: Diego Bordegari 
> Sent: Saturday, June 04, 2005 6:22 PM
> To: 'insight-users-owner at itk.org'
> Subject: cannot post to the Insight-users mailing list
> 
> 
> Dear Owner
> 
> I'd like to post to the 'Insight-users' mailing list and I was wondering
> if you can please help me.
> In fact all the messages I send to the list from diego at cedara.com are
> bouncing back.
> I subscribed the list with two email accounts : dibor at computer.org and
> diego at cedara.com, where dibor at computer.org is simply a forward.
> Following the note
> 
> "If you have more than one email account, you can subscribe them all to
> the list, then set all but one of them to nomail from the mailman web
> GUI"
> 
> I disabled the Mail delivery for dibor at computer.org and I tried to send
> another message but without success. 
> 
> At the beginning of 2002 my post
> http://www.itk.org/pipermail/insight-users/2002-January/000082.html
> 
> was accepted but later other messages were refused. 
> 
> Recently I have been playing with the itk framework to learn about
> registration.
> I wanted to share some info I thought other people might find useful.
> I guess there's something wrong with my account but I don't know what it
> is.
> Is there a way for me to post messages ?
>  
> Thank you in advance for your time.
> 
> Regards,
>  
> - Diego
> 
> 
> 
> -----Original Message-----
> From: insight-users-bounces+diego.bordegari=cedara.com at itk.org
> [mailto:insight-users-bounces+diego.bordegari=cedara.com at itk.org] On
> Behalf Of insight-users-bounces at itk.org
> Sent: Saturday, June 04, 2005 5:14 PM
> To: Diego Bordegari
> Subject: Your message to Insight-users awaits moderator approval
> 
> Your mail to 'Insight-users' with the subject
> 
>     ImageToVTKImageFilter memory leak ?
> 
> will be discarded.  The reason it is being discarded is:
> 
>     Post by non-member to a members-only list
> 
> The mailing lists at Kitware all require membership on the list to post.
> This is to avoid SPAM.  If you are not a member on the list, and you
> post to the list, your message will be discarded.  Do not take it
> personally, we just do not have enough time to approve every email
> posted to the list.  If you have more than one email account, you can
> subscribe them all to the list, then set all but one of them to nomail
> from the mailman web GUI.  Also, some mailers tend to add a few extra
> characters to your return address, if you think you have subscribed, but
> it is still not accepting your email, try sending yourself an email, and
> then reply to it.  Look at the address that you are replying to, and
> make sure that is the EXACT same address that you subscribed to on the
> list.
> 
> You can join the list here:  
>     http://public.kitware.com/mailman/listinfo/Insight-users
> 
> If the message is too large, it will also be discarded, try putting the
> large file on a web server and using a link in your message.
> 
> Bugs can be reported here:
>     http://public.kitware.com/Bug/
> 
>