[Insight-users] Minor bug in new OtsuMultipleThresholdsCalculator?

[lucantiga at softhome.net]

  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime at docserver.cac.washington.edu for more info.

--8323328-1382140891-1078479170=:4486
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.LNX.4.44.0403051033171.4491 at localhost.localdomain>

Hi Zach and Luis,
 attached you can find the corrected versions of 
OtsuMultipleThresholdsCalculator. 

 Basically I defined two types, namely 

 typedef typename NumericTraits<MeasurementType>::RealType MeanType;
 typedef typename NumericTraits<MeasurementType>::RealType VarianceType;

and modified the code accordingly, with all the necessary static_cast's.

 To be consistent, I also changed all comparisons of the kind

if (frequency > 0.0)
 with 
if (NumericTraits<FrequencyType>::IsPositive(frequency))

 and the assignments

mean = 0.0;
 with
mean = NumericTraits<MeanType>::Zero;

 The test passes correctly.

 Therefore, two modifications were made with respect to the CVS version:
 1. Fixed bug in class mean calculation
 2. Fixed type handling 

I also fixed a Doxygen problem in itkOtsuMultipleThresholdsCalculator.h

/** \class itkOtsuMultipleThresholdsCalculator

 was changed to

/** \class OtsuMultipleThresholdsCalculator

 This same thing should also be fixed for 
HistogramAlgorithmBase and ThresholdLabelerImageFilter

Thanks!

Luca


-- 
Luca Antiga, PhD
----------------------------------------------
Biomedical Technologies Laboratory
Bioengineering Department, 
Mario Negri Institute
Villa Camozzi, 24020, Ranica (BG), Italy
----------------------------------------------
phone: +39 035 4535-381
email: antiga at marionegri.it
web:   http://villacamozzi.marionegri.it/~luca
----------------------------------------------

--8323328-1382140891-1078479170=:4486
Content-Type: APPLICATION/X-GZIP; NAME="itkOtsuMultipleThresholdsCalculator.tar.gz"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.4.44.0403051031211.4486 at localhost.localdomain>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME="itkOtsuMultipleThresholdsCalculator.tar.gz"

H4sIALNISEAAA+0aa28bNzKf9St46SGRIluvpAkgyQYcN22Ei+3AVlLk2sCg
tJREa1+3y5XsGr7ffjPkPrgPSWvHPaTFErClFTnDeXNmllwsz4QfnASm4K7J
xguP+QvHNPxjak4DkwrHay2efNvodDud153Okw6MN69fpT7l19cvn8CSXq/z
qvf65RtY/6bb6z0hnW/ct9QIfEE9Qp6YwZRuW7dr/i862i8OHmvUaoR89Jy5
R60+IWRk+3y+EOSCzS1mCyq4Y5Nn5JzNuS889Th2HHPJBQCeOEZgMoQj/zw/
vphxfOBljHNvRf4JCD5Qex7QOaI4bjbhh5+oUPgAo/re63RetTsv250e6fX6
3Zf9HzsS9DPzfKCmL/dmK64euq0ezML0sePeeJKV+rSRsOXMxJp6DKZt3/EE
D6wWOTJNIpf6BEhl3ooZLcBwwRgZjf8VI2qJa0EcjyyEcPvt9nq9bgGrLceb
t9+PTz60k4ULYZEZrDSYoNz0W0gPjPGC+8SPKIDvBsqUTwLBDPLraPz+7NOY
HJ1+Ib8enZ8fnY6/DMiai4UTCMJWzCYKi1gArOWaHIAAkUdtcUOcGTl5d378
HqCO3o4+jMZfkNKfR+PTdxcX5Oezc3JEPh6dj0fHnz4cnYeYPn46/3h28a6l
WEW8dOKsGJnGorMdwafMl8xYDhJtw1dLmgFw9WhG+KJd+4HPbIPNyOVlCfu5
XNR+gMXcZqXXwwb21AwMRp4CwHuQvLT5I3PueCBk6y31WWvxdMMynKnZ1GK+
S6cMTbx2qz1foKP4ICsffq61X7wgv09N6vtkF2E1AksnHgfGjx3LBUtQMM99
0Ee0XIqfkkVMDELh3xcnIK4ZzEEtUn0QE+dMJAtJ4HN7DtoVIxtwx9wQi4FZ
GYTahsTju2zKZzcShx1YE+ahQWkE3MBGazA0IhwyQQORpBotMGmwyyk1TUSD
4L8wm0GYYOC7NNoGgLxAUUhNZ47SbuG+CDNGspON0DEi7OAqMEWFBJwwsWbM
3ldiXVGPUxsV4SMSi15zi/8h3VZi/R3Y9pzA1RVDwMhqgoHnAHlDohCNM4I5
rJXTG+krFyJuMDH5lBTb07AA/21NgSACMBQg0DaoZ4T0iBuXgWH7LaSWRI+7
yblg5mygA0yu2BTCXeAyT2HWZy8s6omPDrcF84YIekjCp42rphAvBVFrMXaK
GECDwE90iizb/f4Jo37gMTxSxrCIZJ4HpZD87LH/BMye3kgUqadiMk4Di3l8
OvYoF/4ws+dhv3/OqBmRY2+kozSWz6FV5gjyhdHvr0AhjjeMtjqUm36WP2a3
1ten2DxMuNYhS0kPjkCB1I0MIJ3PODh5/qdtlBSvPizAkqFNN/MTOvUcX1k3
RFFcI3+q7zLxvdCmGwMFecrWChBtsiHN+3sYil0yDuWHkVukQxwc56CYtH9n
DCRlYORMAkgL+864PGci8Gw/y6FiRHGo4kbCwjM4IYR6rKPWQkxwRLVhYuMJ
1IotBlYem9RylfJP5dqzWWIxeyTAXM+G88N07Pke6e5lPDg1D/4LpweQEtkV
ULERdQqycU9l1FzPESAZZmDo32XudWXSK+6JgJrkvyXW394hgMMNyOchNqNf
1KVhOZBlMmo9Iw5IZ2Sjm0LGgB8NpZ/vzKwirljOsjBh8elKJquWMgnJsJ51
1LcGg3CLkT1VLpbzzhlxIKt0HZ/LWkfuMYGCJwFJxF/fFvqeJWhHaJZR4Id0
SFATn/YyR8AzlQSoqYJAH87HM2CBYFR8hWVSzBecyTYYjMYSnAAelFiKlZQJ
E+syb+UoPC3kWJfqAX31jgxIu00YaAHkJIn5fiznTiOtMDMvXoCpfFx8QLl3
eXJ0+unow+Xo9GIM1dToaDw6O01XBTurW3F9DYUEbMVntejzUev/kkR80x7b
+z+9bu/HbtT/efmmI/s/P3aq/s//Zfzl+z9gnA/oAL0knQ52gDqvqg7Q37gD
VKahAwaUtIDKAtwzjOd6PrcgtaKj5VZrLBT2FQ5ruzYb5iD6/d05Xw0pKjrE
yQHpDuScOr1bMMH/YPWitTKRlYki+K9Zj0Em4PN2vbEX/wAHGTzuKof/zTwH
UN49KDPYKUdVT8RV7r3FClJNapHdWilo4PT7WgUjFeDJMkjPlO6wCYiNqNJ5
JpX5GC6Ku3eyY7VLHjI1fZB1fUs+C356zfScdm46k0dKaqVIN7cx9OaT1uk8
AOq4v3/4S7bXWW/IIjOd99qhE8Sr3nIbfSbGt394ge4iXaMY9BipZggU89fy
Qxg8GSPJWPDlzDQQUbp/NYMnOaFvAWyRpaxE4cuVKo/bsNSxpG0Ersu8RA/E
cNY2LIGIXL868DEeTS+n1BdDAD8sdPb9bmNArg4POvB/f78hnfRW/od9+ExK
UdtgSm1s+PLIVoDEOm+xFlmz53AYwOlAwgZtmFinLFihB6z1rOn8dvWVDDeo
YZ/04G8D9TBzBcV6GFxuw0+kPfY0LmSdGLgG+I2Uv3yeRdKPyFQeNXECIMkg
k5u0i4aYm80C0gfhcR4pVzcCOa1mQw1Hs7H6tSXhR26eNFPGCFYdzxbJspHB
hyJPx+l0GxG83/8oQ8+K1XObNxpx7L6Nv+kMAkf1iPUXRLe7uLtZD5lvkOaG
BWn2tHNExYZCNn/rfG1s3PE+8mo0SHsDmrw4knZCdKgx02e7ZZQ7KW3tiMwj
TWzZly9x5gvd131CjStIO9RLGDBV7hHXg6zXCXw8SiAal7J6QOeCgPkqdAAW
lfCY4dWXB1fN7oAsh4WdAbJsNotsIyfh5VcZkLO/7nfBsFViUmj3Eqy0Gpe6
Zr7F4pe6xet86RqVtD2SJS+VJettqiRdStnWVmpK2peOPG9rOw1GGiLkXHq7
JyPAzJmIas7qcYxNr0SZMe8JS4VIkrwC3H4XxsSQwY47aMU5nBtNeDdH+7kw
vvw6KHD9LaCR6jZFsLxd6lHiEWJ7nrYdsb6AmfYmN9i91wMCaaFVlA6siZmz
a67yFAxzpuO4KEeqZToLCrkAgxpby3VC8InH6DJCqyhHujenTM9FJmkqSFdm
kKc8Vw1u01mjg2VTD1T01cFBp0hDgGGNZXpgGrhbkvxM2JQGQJvKzww4GGKY
sEyZUaA9rwn1eVeLcKepD2GFFzCtugmvLORvLGDpQgrGznIGu/kPqmbSbwD+
nBoCBDM+++msTyi+icAWjOespIz2tIRSKoXQ6ZS5gljIxr7BYRF2p6iZbOcr
jBhzZWrvAy0KVr+OEYPiqU9d17wJ71GE1wzgZ+xUoa2kw6OqX1rht58iNPUG
+ccB6eqJPxfLd9dILUyrV1/D4VPtrkjgS3Pu6my0nobOfBcKJry0EQZseZzs
VsFIoM7AITkqInVkvFXNh/jaQhksWIKkkLzDhgVJ12PaiVIikKRLNgUb/1bq
kFsvuMmgaEIOQfJAoy57jZrmpriKoK3CxGJ7PhzBaQSFSms2JTmD2OU1MjaG
9wzz28rqpDYu7E3JFLAWVm1wTlETLDQVPbbeKcgllpu6Wjn6rgZxsYz174Yk
9yrKEJSKikrXA4JpcuIAW8m16PVn6o0zaAoS5EHGl5JUDIOEzNAgJwtFpmXv
+b7CRWDlrDubJeRMXCM5fZTXM3pthGIkkRwL0qyMEPMF7kPq24i15saKGo25
THKa9eT9CDeiybZviqRZECvSfa8kh9klPq0RslmAj1TRRxlEplJ9WF1zlapi
ksRo+16lkjeFLBJ+M91fKZs/x3YjffRPyZs1696crtZTVUy56AoWGXJfulOx
MeFGYcZ6KUVxCR3dKUfR77yFke6tuqqZQ6Mv1VBtCSQ5L0hvkDkxU/gLbCEj
+/RyXUf7KWtDuC2zmTyIXbsmviajponNfZ9PTKYXB4494/NAvUhV91mmC8fx
1cs3fCMgb7zecIYHpbzXCvZffPk1SS7wqk9xQz/fstc79VpnPtOE14WeUvHq
3votq+EkYKy+TxXHBSVGEo3Gw7RZZrnJOkUCOUitKJUg6NExSb3dG/jnYWfP
sQ288T3hNmJVncLI9tS1vFrpl4IZ3yyVLEWoi074txzKi+t6Z6+YXz1c3+1+
ofrgSvG+l+NkLZlcpNYRAEi4VErL8clwGALjt6d5gfXJU5wpvndVhEKJE8Di
UJlJae+hHIVcVxHuoFAro1IrpFygUDFlqR9fm9p+qSp7o+pPuPVUjWpUoxrV
qEY1qlGNalSjGtWoRjWqUY1qVKMa1ahGNarx9x3/A9V6nOgAUAAA
--8323328-1382140891-1078479170=:4486--