[ITK-dev] itkStaticAssert warnings with clang

[Poughon Victor]

Hello,

I made a patch for this issue, but I'm having trouble with gerrit-push over http (I'm behind a firewall and proxy):

$ git gerrit-push
Fetching gerrit master
Pushing to gerrit
remote: Unauthorized
fatal: Authentication failed for 'http://vpoughon@review.source.kitware.com/p/ITK/'

Not sure why it's not working, I followed instructions from the wiki. Maybe it's related to the issue my colleague was having:
http://permalink.gmane.org/gmane.comp.lib.itk.devel/3159

So here is a format-patch.

Thanks,

Victor Poughon
________________________________
De : Dženan Zukić [dzenanz at gmail.com]
Envoyé : lundi 4 janvier 2016 17:23
À : Poughon Victor
Cc : insight-developers at itk.org
Objet : Re: [ITK-dev] itkStaticAssert warnings with clang

Hi Victor,

this is an excellent opportunity for you to contribute<http://www.itk.org/Wiki/ITK/Contribute> to ITK the patch which fixes the described issue. Add Matt McCormick as one of the reviewers.

Regards,
Dženan

On Mon, Jan 4, 2016 at 8:30 AM, Poughon Victor <Victor.Poughon at cnes.fr<mailto:Victor.Poughon at cnes.fr>> wrote:
Hi all,

I think there is an issue in itkStaticAssert causing a large number of warnings (199) when building with clang 3.5.0. Here is a clean dashboard build of the current master branch showing the warnings:
https://open.cdash.org/viewBuildError.php?type=1&buildid=4174833

This was previously discussed on OTB's mailing list:
https://groups.google.com/forum/#!searchin/otb-developers/itkStaticAssert/otb-developers/X8Bfvzh8g-A/T9basCNfCAAJ

They are caused by __attribute__(error(str)) being used, which is a GCC specific attribute. I will quote my colleague Luc Hermitte:

> clang defines GCC macros (__GNUC__ & all).
> The #if should also test for !defined(__clang__).

When building with this version of clang:
clang version 3.5.0 (tags/RELEASE_350/final)
Target: x86_64-redhat-linux-gnu
Thread model: posix

Happy 2016,

Victor Poughon




_______________________________________________
Powered by www.kitware.com<http://www.kitware.com>

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://public.kitware.com/mailman/listinfo/insight-developers

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160105/c9cd6f40/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-COMP-fix-itkStaticAssert-warnings-with-clang.patch
Type: text/x-patch
Size: 1260 bytes
Desc: 0001-COMP-fix-itkStaticAssert-warnings-with-clang.patch
URL: <http://public.kitware.com/pipermail/insight-developers/attachments/20160105/c9cd6f40/attachment.bin>