
<html dir="ltr">


<head>


<meta http-equiv="Content-Type" content="text/html; charset=utf-8">


<style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>


</head>


<body ocsi="0" fpstyle="1">


<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Hello,<br>


<br>


I made a patch for this issue, but I'm having trouble with gerrit-push over http (I'm behind a firewall and proxy):<br>


<br>


$ git gerrit-push<br>


Fetching gerrit master<br>


Pushing to gerrit<br>


remote: Unauthorized<br>


fatal: Authentication failed for 'http://vpoughon@review.source.kitware.com/p/ITK/'<br>


<br>


Not sure why it's not working, I followed instructions from the wiki. Maybe it's related to the issue my colleague was having:<br>


http://permalink.gmane.org/gmane.comp.lib.itk.devel/3159<br>


<br>


So here is a format-patch.<br>


<br>


Thanks,<br>


<br>


Victor Poughon


<div style="font-family: Times New Roman; color: #000000; font-size: 16px">


<hr tabindex="-1">


<div style="direction: ltr;" id="divRpF334263"><font color="#000000" face="Tahoma" size="2"><b>De :</b> Dženan Zukić [dzenanz@gmail.com]<br>


<b>Envoyé :</b> lundi 4 janvier 2016 17:23<br>


<b>À :</b> Poughon Victor<br>


<b>Cc :</b> insight-developers@itk.org<br>


<b>Objet :</b> Re: [ITK-dev] itkStaticAssert warnings with clang<br>


</font><br>


</div>


<div></div>


<div>


<div dir="ltr">


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


Hi Victor,</div>


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


<br>


</div>


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


this is an excellent opportunity for you to <a href="http://www.itk.org/Wiki/ITK/Contribute" target="_blank">


contribute</a> to ITK the patch which fixes the described issue. Add Matt McCormick as one of the reviewers.</div>


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


<br>


</div>


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


Regards,</div>


<div class="gmail_default" style="font-family:verdana,sans-serif; font-size:small">


Dženan</div>


</div>


<div class="gmail_extra"><br>


<div class="gmail_quote">On Mon, Jan 4, 2016 at 8:30 AM, Poughon Victor <span dir="ltr">


<<a href="mailto:Victor.Poughon@cnes.fr" target="_blank">Victor.Poughon@cnes.fr</a>></span> wrote:<br>


<blockquote class="gmail_quote" style="margin:0 0 0 .8ex; border-left:1px #ccc solid; padding-left:1ex">


Hi all,<br>


<br>


I think there is an issue in itkStaticAssert causing a large number of warnings (199) when building with clang 3.5.0. Here is a clean dashboard build of the current master branch showing the warnings:<br>


<a href="https://open.cdash.org/viewBuildError.php?type=1&buildid=4174833" rel="noreferrer" target="_blank">https://open.cdash.org/viewBuildError.php?type=1&buildid=4174833</a><br>


<br>


This was previously discussed on OTB's mailing list:<br>


<a href="https://groups.google.com/forum/#!searchin/otb-developers/itkStaticAssert/otb-developers/X8Bfvzh8g-A/T9basCNfCAAJ" rel="noreferrer" target="_blank">https://groups.google.com/forum/#!searchin/otb-developers/itkStaticAssert/otb-developers/X8Bfvzh8g-A/T9basCNfCAAJ</a><br>


<br>


They are caused by __attribute__(error(str)) being used, which is a GCC specific attribute. I will quote my colleague Luc Hermitte:<br>


<br>


> clang defines GCC macros (__GNUC__ & all).<br>


> The #if should also test for !defined(__clang__).<br>


<br>


When building with this version of clang:<br>


clang version 3.5.0 (tags/RELEASE_350/final)<br>


Target: x86_64-redhat-linux-gnu<br>


Thread model: posix<br>


<br>


Happy 2016,<br>


<br>


Victor Poughon<br>


<br>


<br>


<br>


<br>


_______________________________________________<br>


Powered by <a href="http://www.kitware.com" rel="noreferrer" target="_blank">www.kitware.com</a><br>


<br>


Visit other Kitware open-source projects at<br>


<a href="http://www.kitware.com/opensource/opensource.html" rel="noreferrer" target="_blank">http://www.kitware.com/opensource/opensource.html</a><br>


<br>


Kitware offers ITK Training Courses, for more information visit:<br>


<a href="http://kitware.com/products/protraining.php" rel="noreferrer" target="_blank">http://kitware.com/products/protraining.php</a><br>


<br>


Please keep messages on-topic and check the ITK FAQ at:<br>


<a href="http://www.itk.org/Wiki/ITK_FAQ" rel="noreferrer" target="_blank">http://www.itk.org/Wiki/ITK_FAQ</a><br>


<br>


Follow this link to subscribe/unsubscribe:<br>


<a href="http://public.kitware.com/mailman/listinfo/insight-developers" rel="noreferrer" target="_blank">http://public.kitware.com/mailman/listinfo/insight-developers</a><br>


</blockquote>


</div>


<br>


</div>


</div>


</div>


</div>


</body>


</html>