[Insight-developers] OpenJPEG 2000

[Julien Malik]

You're right, seems it got broken before releasing 2.0, I can reproduce it.
Not tested on the dashboard -> not working :(

Julien


On 05/24/2013 03:13 PM, Bradley Lowekamp wrote:
> Hello,
>
> The name mangling will be quite nice. Have you tried it yourself? This is what I am getting with the 2.0.0 release and I believe the trunk:
>
> $  cmake -DOPENJPEG_NAMESPACE=itk ~/src/openjpeg-2.0.0/
> -- The C compiler identification is GNU 4.4.7
> -- Check for working C compiler: /usr/lib64/ccache/cc
> -- Check for working C compiler: /usr/lib64/ccache/cc -- works
> -- Detecting C compiler ABI info
> -- Detecting C compiler ABI info - done
> -- Check if the system is big endian
> -- Searching 16 bit integer
> -- Looking for sys/types.h
> ...
> -- Found TIFF: /usr/lib64/libtiff.so (found version "3.9.4")
> -- Your system seems to have a TIFF lib available, we will use it
> -- Could NOT find LCMS2 (missing:  LCMS2_LIBRARY LCMS2_INCLUDE_DIR)
> -- Could NOT find LCMS (missing:  LCMS_LIBRARY LCMS_INCLUDE_DIR)
> -- LCMS2 or LCMS lib not found, activate BUILD_THIRDPARTY if you want build it
> CMake Error: File /cmake/OpenJPEGConfig.cmake.in does not exist.
> CMake Error at CMakeLists.txt:292 (configure_file):
>    configure_file Problem configuring file
>
>
> It looks like some cmake variable are still defined based on a hard coded OPENJPEG project name.
>
> Am I doing something wrong?
>
> Brad
>
> On May 23, 2013, at 9:04 AM, Julien Malik <julien.malik at c-s.fr> wrote:
>
>> Hi Brad,
>>
>> Opening the link to the header file you provided, I was surprised to see the "1.2.0" version number : that's quite old !
>> You should definitely think about switching to version 2, which provides streamed reading and writing.
>> There are a few API changes with v2, though.
>>
>> Also, there is a CMake variable providing automatic "mangling" of the library, so that symbols can be prefixed with "itk_" for example.
>>
>> Support for an external build of openjpeg would be great too.
>>
>> Julien
>>
>> On 05/23/2013 02:53 PM, Bradley Lowekamp wrote:
>>> Interesting thing OpenJpeg was upgraded to utilize CMake by Mathieu Malaterre. Hopefully that will make things easier.
>>>
>>>
>>> I think we need to be better about keeping some of our libraries up to date. So I am aware of the git subtree merge, when you have another git repository for a sub project.
>>>
>>> I recall a simular technique for when the imported code if from a tarball. Any one have a link to some documentation on that?
>>>
>>> Thanks,
>>> Brad
>>>
>>>
>>> On May 23, 2013, at 8:09 AM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
>>>
>>>> Hi,
>>>>
>>>> I will suppose then that the best corse of action is to upgrade the openjpeg library.
>>>>
>>>> Is there any particular advice for this upgrade? Or is just dropping in the new code likely going to work?
>>>>
>>>> Thanks,
>>>> Brad
>>>>
>>>> On May 22, 2013, at 4:26 PM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> I was going over some failing tests on windows debug systems, that are getting forgotten. Some of them are related to JPEG 2000. This is an interesting on.
>>>>>
>>>>> This library is compiled a  "C" library yet we use it from c++. The size of the bool type is not matching up on either size on C++ is a byte, while on C is an int.
>>>>>
>>>>> You can see how this unfortunately happens here:
>>>>>
>>>>> https://github.com/Kitware/ITK/blob/master/Modules/ThirdParty/OpenJPEG/src/openjpeg/openjpeg.h#L50
>>>>>
>>>>> It appears they have fixed this in the latest OpenJPEG 1.5.1 release...
>>>>>
>>>>> What should be do?
>>>>>
>>>>> Brad
>>>>>
>>>>> _______________________________________________
>>>>> Powered by www.kitware.com
>>>>>
>>>>> Visit other Kitware open-source projects at
>>>>> http://www.kitware.com/opensource/opensource.html
>>>>>
>>>>> Kitware offers ITK Training Courses, for more information visit:
>>>>> http://kitware.com/products/protraining.php
>>>>>
>>>>> Please keep messages on-topic and check the ITK FAQ at:
>>>>> http://www.itk.org/Wiki/ITK_FAQ
>>>>>
>>>>> Follow this link to subscribe/unsubscribe:
>>>>> http://www.itk.org/mailman/listinfo/insight-developers
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Kitware offers ITK Training Courses, for more information visit:
>>> http://kitware.com/products/protraining.php
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>