[Insight-developers] Refactoring of ProcessObject's names inputs

[Matt McCormick]

Hi Brad,

These both seem like good changes.  Since the constructed name was
never exposed, this should not be a big compatibility issue.

Thanks,
Matt

On Mon, May 6, 2013 at 8:05 PM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
> Hello all,
>
> I broke out part of this original topic into another one which just adds a global variable to store the first 100 named index inputs:
>
> http://review.source.kitware.com/#/c/10959/6
>
> I am also proposing that we rename the default name of inputs from "IndexedDataObjects"## to just "_"##:
> http://review.source.kitware.com/#/c/11152/1/Modules/Core/Common/src/itkProcessObject.cxx
>
> It just does not make since to compare 17 characters before the part that is different ( the number ) for the indexed inputs. There is no other code outside of the ProcessObject that needs to be changed in ITK. The only code which could be effected by this change are filters written which mix usage of using numbers and strings for inputs. I believe there is a good change this does not exist anywhere.
>
> What do people think of the change in terms of compatibility? Anything beside a migration guide need to be written?
>
> Thanks,
> Brad
>
> On May 2, 2013, at 2:18 PM, Bradley Lowekamp <blowekamp at mail.nih.gov> wrote:
>
>> Hello all,
>>
>> I have been working on this topic [1] to improve how the process object's inputs are accessed. It reduces the number of strings which need to allocated in many methods, makes set/get of indexed inputs constant time access, and it also adds support for names indexed inputs [2] to migration old classes to the named inputs approach [3].
>>
>> I think this is an important change to make it into 4.4, and that deadline is fast approaching, so I could use some eyes on it, and some checks with external projects.
>>
>> Thanks,
>> Brad
>>
>> [1] http://review.source.kitware.com/#/q/status:open+project:ITK+branch:master+topic:NamedInputsCompatibility,n,z
>> [2] http://review.source.kitware.com/#/c/11022/
>> [3] http://review.source.kitware.com/#/c/11023/
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers