[Insight-developers] ITK bugs & patches -- openJPEG

[Williams, Norman K]

 I have the simple patch up for review, we'll see what people think. I'm CC'ing the developer list.

http://review.source.kitware.com/#/c/11133/

If it gets moved there, then I wonder about how applications would deal with it.  Normally if a library is installed (either system-wide, per user, or as part of a build) you would be able to just have:



#include "openjpeg.h"



And not have any additional path.  Having an ITK-specific path would mean that the build would no longer work if ITK and your application build were configured against a system OpenJPEG.



________________________________
From: Marco Feuerstein [marco.feuerstein at gmail.com]
Sent: Friday, May 03, 2013 2:37 AM
To: Williams, Norman K
Subject: Re: ITK bugs & patches -- openJPEG

Kent,

the rationale for installing it to ${ITK3P_INSTALL_INCLUDE_DIR}/itkopenjpeg for me was that all other external headers from libs like jpeg, png, tiff, zlib, ... are currently installed to itkjpeg, itkpng, itktiff, itkzlib, ... directories.
I just wanted to be conform to this behavior.
What do you think? Shall we be different just for openjpeg?
Thanks for your help!

Best,
Marco


On Thu, May 2, 2013 at 10:20 PM, Williams, Norman K <norman-k-williams at uiowa.edu<mailto:norman-k-williams at uiowa.edu>> wrote:
I'm looking at this Jira task you logged for ITK

https://itk.icts.uiowa.edu/jira/browse/ITK-3025

I've verified that this is indeed a problem.  Have you set up an account
for submitting patches on
http://review.source.kitware.com? Gerrit provides a way to submit patches
and get feedback on them.

Regarding your patch:
https://itk.icts.uiowa.edu/jira/secure/attachment/12316/itkopenjpeg.patch

It seems to me that it is true that openjpegDllConfig.h should be included
in the installation. What isn't clear to me is why the destination needs
to be ${ITK3P_INSTALL_INCLUDE_DIR}/itkopenjpeg.  Was there a rationale for
this?

BTW the default now for header installation from ITK is to put all ITK
header files into one directory
--
Kent Williams norman-k-williams at uiowa.edu<mailto:norman-k-williams at uiowa.edu>






________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20130503/4bca6d08/attachment.htm>