[Insight-developers] Why are headers in Modules/NonUnit/Review/include not installed when ITK_USE_REVIEW is on?

[Xiaoxiao Liu]

If the ITKReview module is enabled in the building process, it should
behave the same as any other module in ITK, namely, the headers should be
included.

This patch is fixing the bug ( in which the module is not enabled by
turning ITK_USE_REVIEW ON):
http://review.source.kitware.com/#/c/12259/

Will you mind double checking your build tree to make sure the ITKReview
module is enabled?






On Thu, Aug 15, 2013 at 11:02 AM, Williams, Norman K <
norman-k-williams at uiowa.edu> wrote:

> OK, so you would go from someone setting ITK_USE_REVIEW to setting
> Module_ITKReview, fair enough.
>
> I still don't understand why I can do an install from an ITK build and the
> headers in Modules/NonUnit/Review/include
> are not copied.
>
> This is the revision we're currently settled on, coincidentally one of
> your checkins:
>
> commit c3624fafeb15f042839a8e6c463970e75ad40777
> Merge: 74f8fbc 29e8b58
> Author: Matt McCormick <matt.mccormick at kitware.com>
> Date:   Thu Jul 25 21:39:33 2013 -0400
>
>     Merge topic 'yvvGaussian'
>
>     29e8b58 ENH: YVV remote module - Add EXCLUDE_FROM_ALL option to
> itk_module.
>     ef8069f ENH: Remote module: GPU and CPU Smoothing recursive YVV
> Gaussian Filter
>
>
>
> --
> Kent Williams norman-k-williams at uiowa.edu
>
>
>
>
>
>
> On 8/15/13 9:44 AM, "Matt McCormick" <matt.mccormick at kitware.com> wrote:
>
> >Hi Kent,
> >
> >We are in the process of deprecating ITK_USE_REVIEW due to incorrect
> >and complicated interaction with the Module_ITKReview variable.  Are
> >you observing this behavior with recent master?
> >
> >Thanks,
> >Matt
> >
> >On Thu, Aug 15, 2013 at 2:26 PM, Williams, Norman K
> ><norman-k-williams at uiowa.edu> wrote:
> >> I don't have time to read through all of the CMake magic involved in ITK
> >> Modularization, so I'm hoping someone on the list knows what's up: Some
> >> projects that succeed when built against an ITK build tree fail when
> >>built
> >> against an ITK install, because they use headers from Review.  For
> >>example
> >> itkLabelGeometryImageFilter.h
> >>
> >> Is there something that is suppressing the installation of the
> >> NonUnit/Review stuff?
> >>
> >> --
> >> Kent Williams norman-k-williams at uiowa.edu
> >>
> >>
> >>
> >>
> >>
> >>
> >> ________________________________
> >> Notice: This UI Health Care e-mail (including attachments) is covered
> >>by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
> >>confidential and may be legally privileged.  If you are not the intended
> >>recipient, you are hereby notified that any retention, dissemination,
> >>distribution, or copying of this communication is strictly prohibited.
> >>Please reply to the sender that you have received the message in error,
> >>then delete it.  Thank you.
> >> ________________________________
> >> _______________________________________________
> >> Powered by www.kitware.com
> >>
> >> Visit other Kitware open-source projects at
> >> http://www.kitware.com/opensource/opensource.html
> >>
> >> Kitware offers ITK Training Courses, for more information visit:
> >> http://kitware.com/products/protraining.php
> >>
> >> Please keep messages on-topic and check the ITK FAQ at:
> >> http://www.itk.org/Wiki/ITK_FAQ
> >>
> >> Follow this link to subscribe/unsubscribe:
> >> http://www.itk.org/mailman/listinfo/insight-developers
>
>
>
> ________________________________
> Notice: This UI Health Care e-mail (including attachments) is covered by
> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
> confidential and may be legally privileged.  If you are not the intended
> recipient, you are hereby notified that any retention, dissemination,
> distribution, or copying of this communication is strictly prohibited.
>  Please reply to the sender that you have received the message in error,
> then delete it.  Thank you.
> ________________________________
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 


---------------------------------------------
*Xiaoxiao Liu*, Ph.D.
R & D Engineer
Kitware Inc <http://www.kitware.com/>.
Clifton Park, NY
Phone: (518) 881-4924  or  (518) 371-3971 x124
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20130815/e57f6630/attachment.htm>