[Insight-developers] API change of vnl_math to namespace

[Bill Lorensen]

Is there any reason for us to be using vnl_math?

On Wed, Oct 31, 2012 at 5:02 PM, Sean McBride <sean at rogue-research.com>wrote:

> On Wed, 31 Oct 2012 20:47:57 +0000, Matt McCormick said:
>
> >Hi,
> >
> >Recently, changes were made in vnl_math.h so that vnl_math_abs is now
> >vnl_math::abs, etc.
> >
> >This is causing pain in ITK :-(.
> >
> >What is the recommended way to deal with this change in a
> >backwards-compatible way?  I could not find pre-processor version
> >definitions in core/vnl/vnl_config.h or core/vxl_config.h
>
> This is partly my fault... and is ironic because the change was meant to
> *help* ITK. :(
>
> I submitted a patch to the vxl folks based on this:
> <http://review.source.kitware.com/#/c/6025/>
>
> see the thread "Patch from ITK (Avoid C++0x constexpr error)" on the vxl
> list.  After some discussion about whether to accept the patch or not, it
> was accepted (but expanded on!) and committed in r35854 (and perhaps
> others).
>
> I'm not sure why Peter made even more extensive changes... Peter?
>
> Cheers,
>
> --
> ____________________________________________________________
> Sean McBride, B. Eng                 sean at rogue-research.com
> Rogue Research                        www.rogue-research.com
> Mac Software Developer              Montréal, Québec, Canada
>
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>



-- 
Unpaid intern in BillsBasement at noware dot com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20121031/fc1c9c85/attachment.htm>