[Insight-developers] DimensionType

[Matt McCormick]

Thanks, Steven.

To add a comment in to a change set in Gerrit, hit the 'Review' button
on near the middle of the page.

It is fine to continue modifying this patch.

Many thanks,
Matt

On Fri, Apr 27, 2012 at 12:03 PM, Steven L <steventhewhite42 at yahoo.com> wrote:
> Sure.
>
> Is there a way for me to comment on gerrit? Couldn't quite find anything, and wasn't sure whether I should directly contact Bradley or not for confirmation of it.
>
> Would you like me to make it a new patch, or continue modifying this one?
> Regardless, I'll work on it tonight / this weekend.
>
>      Steven Leblanc
>
>
>
> ----- Original Message -----
> From: Matt McCormick <matt.mccormick at kitware.com>
> To: steventhewhite42 at yahoo.com
> Cc: ITK <insight-developers at itk.org>; Bradley Lowekamp <blowekamp at mail.nih.gov>
> Sent: Friday, April 27, 2012 11:53 AM
> Subject: Re: [Insight-developers] DimensionType
>
> Hi Steven,
>
> Are you willing to take on this issue?  It would involve updating the
> code in Modules/Core/Common.
>
> Thanks,
> Matt
>
> On Thu, Apr 26, 2012 at 12:56 PM, Bradley Lowekamp
> <blowekamp at mail.nih.gov> wrote:
>> Hello,
>>
>> I left a comment on this issue in gerrit, but it is a bit far back in the
>> history now so I'll post it here:
>>
>> I'd prefer consistant unsigned int usage as opposed to inconsistent usage of
>> this typedef.
>> I don't believe it is reasonable to go through all of ITK to make this
>> consistent. I think at minimal Common/Core should use these kind of best
>> practice. Even after all off the ITKv4 effort we are still finding many
>> places where SizeType is not being used as it should be.
>>
>> Brad
>>
>> On Apr 24, 2012, at 8:05 PM, Matt McCormick wrote:
>>
>> Hi all,
>>
>> This patch set is of broad interest:
>>
>>  http://review.source.kitware.com/#/c/5299/
>>
>> It proposes adding a new typedef to itkIntTypes.h, "DimensionType".
>> This typedef is to be used for image dimensions, etc, where as-of-yet
>> the raw 'unsigned int' is usually applied for image dimensions.  By
>> adopting this typedef, we can make the code more readable.  And, at
>> some point in the future, we will have the ability to easily change
>> its type if desired.
>>
>> Matt
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.php
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
>> ========================================================
>>
>> Bradley Lowekamp
>>
>> Medical Science and Computing for
>>
>> Office of High Performance Computing and Communications
>>
>> National Library of Medicine
>>
>> blowekamp at mail.nih.gov
>>
>>
>>
>>
>