[Insight-developers] boundary faces calculator bug

[wanlin]

Hi,
   The current implementation of BoundaryFacesCalculator is based on the
following assumption.

There is an overlap between requestToProcessRegion and nonBounaryRegion of
BufferedRegion.

Hence the first region in the output list is the nonBoundaryRegion in
requestToProcessRegion.

In your test, there is no overlap between requestToProcessRegion and
bufferedRegion since requstToProcessRegion index[Dimension-1] = 1, which
bufferedRegion index[Dimension - 1] = 0, size[Dimension - 1]  = 1, . The
ideal results ought to output 0 regions.

Should we change the implementationso the calculator could deal with any
cases of requestToProcessRegion and BufferedRegion? I am willing to put a
patch.


thanks


wanlin


On Tue, Apr 17, 2012 at 9:21 AM, Kris Zygmunt <krismz at sci.utah.edu> wrote:

> Hi,
>   While trying to compare results between itkScalarAnisotropicDiffusionF**unction
> and itkGPUScalarAnisotropicDiffusi**onFunction, I found a bug in the
> NeighborhoodAlgorithm::**BoundaryFacesCalculator when one of the image
> sizes is 1 ie a 3D image with size [5,5,1] (I cloned itk 4 today and the
> bug is still in master).  In this case, the calculator repeats the final
> region twice.  It seems like this might have been addressed once before in
> ITK 3.20 just before 4.0, but that may have been another bug or that fix
> might have introduced this bug.
>
> Anyway, I have been able to modify the test to demonstrate this bug and
> have put that patch at http://review.source.kitware.**com/#/c/5213/<http://review.source.kitware.com/#/c/5213/>.  This may change the answer from some tests if they are unlucky enough to
> be using images that fall into this image size condition.
>
> -Kris
> ______________________________**_________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/**opensource/opensource.html<http://www.kitware.com/opensource/opensource.html>
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/**protraining.php<http://kitware.com/products/protraining.php>
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_**FAQ <http://www.itk.org/Wiki/ITK_FAQ>
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/**listinfo/insight-developers<http://www.itk.org/mailman/listinfo/insight-developers>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/pipermail/insight-developers/attachments/20120417/97dd044b/attachment.htm>