[Insight-developers] Change in ITK[master]: ENH: add support for named input and output in filters

[Bill Lorensen]

I cherry-picked 1653, 2685, 2686 and 2687, in that order.

Then I built Slicer4. Although the build had many overloaded virtual
function warnings (I will have a patch for them),  Slicer4 built without
compile errors (I have not run the tests).

I also cherry-picked 1653 alone and rebuilt ITK. My goal was to see if the
changes were backward compatible with existing filters. Once again I had
many overloaded virtual function, but itk built without errors.\

These experiments tell me that Gaetan's changes are backward compatible. I
recommend that we merge them today, assuming all robot builds pass.

CAVEAT: my slow machines are still building, but I assume there will be no
surprises.

Bill


On Fri, Sep 9, 2011 at 12:46 PM, Code Review <review at kitware.com> wrote:

> From Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>
> Gaëtan Lehmann has posted comments on this change.
>
> Change subject: ENH: add support for named input and output in filters
> ......................................................................
>
>
> Patch Set 12:
>
> Luis, Jim, Brad,
>
> Would you get a chance to review that change?
>
> --
> To view, visit http://review.source.kitware.com/1653
> To unsubscribe, visit http://review.source.kitware.com/settings
>
> Gerrit-MessageType: comment
> Gerrit-Change-Id: I4d77e252f85e04caaa37a385742c89c3e0ff30fd
> Gerrit-PatchSet: 12
> Gerrit-Project: ITK
> Gerrit-Branch: master
> Gerrit-Owner: Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>
> Gerrit-Reviewer: Bill Lorensen <bill.lorensen at gmail.com>
> Gerrit-Reviewer: Bradley Lowekamp <blowekamp at mail.nih.gov>
> Gerrit-Reviewer: Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>
> Gerrit-Reviewer: Hans J. Johnson <hans-johnson at uiowa.edu>
> Gerrit-Reviewer: Jim Miller <millerjv at ge.com>
> Gerrit-Reviewer: Luis Ibanez <luis.ibanez at kitware.com>
> Gerrit-Reviewer: Matt McCormick <matt.mccormick at kitware.com>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110909/0b6812f4/attachment.htm>