[Insight-developers] Composite Transform Read/Write patch prematurely merged

[Williams, Norman K]

I'll work on a patch to do this. IT is a good thing to keep the ability to read separate transforms.  The one way it would be good to keep external transforms as part of the write code would be to not try and store DisplacementField transforms in-line in a text transform -- though if it came to that we could base64-encode the image data and the overhead wouldn't be that terrible.
But that's part of a separate issue -- it is now possible to create DisplacementField transforms, but there isn't any method to read or write them.  By default there's no factory installed for them.
Of course the main purpose of the transform hierachy and how it's set up is to support registration, and I don't think trying to register images by directly optimizing a displacement field would be absurd and ineffective.


________________________________________
From: M Stauffer (V) [mstauff at verizon.net]
Sent: Friday, October 14, 2011 4:51 PM
To: Williams, Norman K; 'ITK'
Subject: RE: [Insight-developers] Composite Transform Read/Write patch  prematurely merged

Kent, looks good. I haven't tested it myself though.

The only thing I see is that the unused
TxtTransformIO::ReadComponentFile method is still in there. I think it
should be removed to avoid confusion, or the code be restored to write
out a TxT-format file as a list of filenames. At the very list the
comment for TxtTransformIO::ReadComponentFile should say that it's not
used.

-M

>-----Original Message-----
>From: insight-developers-bounces at itk.org
>[mailto:insight-developers-bounces at itk.org] On Behalf Of
>Williams, Norman K
>Sent: Friday, October 14, 2011 1:40 PM
>To: ITK
>Subject: [Insight-developers] Composite Transform Read/Write
>patch prematurely merged
>
>
>I think I must have typed gerrit-merge when I meant
>gerrit-push, but the
>CompositeTransform enhancement to itkTransformReader/Writer appears to
>have been merged.
>
>The topic is here: http://review.source.kitware.com/#change,3075
>
>I have high confidence in the correctness of the patch, but it didn't
>actually get reviewed & approved by anyone. So far it looks OK on
>continuous builds, but I'm wondering if anyone thinks it
>should be backed
>out?
>
>
>
>________________________________
>Notice: This UI Health Care e-mail (including attachments) is
>covered by the Electronic Communications Privacy Act, 18
>U.S.C. 2510-2521, is confidential and may be legally
>privileged.  If you are not the intended recipient, you are
>hereby notified that any retention, dissemination,
>distribution, or copying of this communication is strictly
>prohibited.  Please reply to the sender that you have received
>the message in error, then delete it.  Thank you.
>________________________________
>_______________________________________________
>Powered by www.kitware.com
>
>Visit other Kitware open-source projects at
>http://www.kitware.com/opensource/opensource.html
>
>Kitware offers ITK Training Courses, for more information visit:
>http://kitware.com/products/protraining.html
>
>Please keep messages on-topic and check the ITK FAQ at:
>http://www.itk.org/Wiki/ITK_FAQ
>
>Follow this link to subscribe/unsubscribe:
>http://www.itk.org/mailman/listinfo/insight-developers


________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________