[Insight-developers] ITK Wrapping Regressions

[Johnson, Hans J]

90% of TCL works, so I spent several days effort to use it as an
intermediate stepping stone to Python.  Then I discovered this error where
process objects seem to work perfectly, but when the image is returned
(using GetOutput), you can not interrogate the Spacing of that image.

I am OK it TCL is not supported, but at a minimum, you should be able to
ask an image what it's spacing is without failing.

I would propose that TCL is either fixed, or removed completely.

Thanks!
Hans

PS:  I am giving my final exam in the ITK course I teach during the
teleconference this Friday.


On 5/9/11 11:30 PM, "Alexandre GOUAILLARD" <agouaillard at gmail.com> wrote:

>hi hans,
>
>let's speak about it at this friday TConf.
>
>From our previous discussions at the meetings, we had decided tcl
>would be a second class citizen. Just like the code not compiling
>under msvc 6 anymore is not a regression but a choice, the wrapping
>not supporting tcl would then not be a regression.
>
>If tcl is a blocker for a big external project like yours, we might
>decide to upgrade tcl to first class citizen. Alternatively, would
>moving away from tcl something that you might consider as well? From
>our previous discussions it seemed that it was somehow in your
>roadmap. My concern here is that if we decide to actively support tcl,
>it's for another 10 years.
>
>separate but related topic: quick work around.
>
>Gaethan is very busy right now, our new wrapping software engineer
>ashish is still learning, and I'm putting DICOM back on track full
>time untill sunday. I will have some time next week to investigate and
>see if we can come up with a quick solution to help you.
>
>best regards
>
>alex.
>
>On Tue, May 10, 2011 at 9:45 AM, Johnson, Hans J <hans-johnson at uiowa.edu>
>wrote:
>> I've discovered some wrapping that is working in ITKv3 that does not
>>work in
>> ITKv4.  Should I submit tests that will fail that expose this problem?
>> I am trying to figure out TCL wrapping in ITKv4 now.
>> I think I have narrowed it down to a minimal test case that identifies
>>some
>> missing functionality that was in ITKv3, but does not work in ITKv4.
>> =THE TEST CODE (Used in both ITKv3 and ITKv4) ===========
>> [johnsonhj at hjhomebuildbox ~]$ cat /tmp/MinimalTest.tcl
>> package require InsightToolkit
>> set reader [ itkImageFileReaderIUC2_New ]
>> $reader SetFileName /tmp/tmp.png
>> $reader Update
>> set myImage [ $reader  GetOutput ]
>> puts [$myImage GetSpacing]
>> =SUCCESS WITH ITKv3 ===========================
>> [johnsonhj at hjhomebuildbox ~]$ tclsh /tmp/MinimalTest.tcl
>> libpng warning: Ignoring truncated iCCP profile.
>> libpng warning: Ignoring truncated iCCP profile.
>> _a8598e0201000000_p_itk__VectorTdouble_2u_t
>> =FAILURE   WITH ITKv4 ==========================
>> [johnsonhj at hjhomebuildbox ~]$ tclsh /tmp/MinimalTest.tcl
>> libpng warning: Ignoring truncated iCCP profile.
>> libpng warning: Ignoring truncated iCCP profile.
>> invalid command name "_20c5100901000000_p_itkImageUC2"
>>     while executing
>> "$myImage GetSpacing"
>>     invoked from within
>> "puts [$myImage GetSpacing]"
>>     (file "/tmp/MinimalTest.tcl" line 7)
>>
>> This is the last failing component for our PHASE I conversion from
>>ITKv3 to
>> ITKv4.
>> Any fixes or work-arounds would be greatly appreciated.
>> Thanks,
>> Hans
>>
>> ________________________________
>> Notice: This UI Health Care e-mail (including attachments) is covered
>>by the
>> Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>>confidential
>> and may be legally privileged.  If you are not the intended recipient,
>>you
>> are hereby notified that any retention, dissemination, distribution, or
>> copying of this communication is strictly prohibited.  Please reply to
>>the
>> sender that you have received the message in error, then delete it.
>>Thank
>> you.
>> ________________________________
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________