[Insight-developers] Alpha 09 tagging

Tue Aug 9 12:43:24 EDT 2011

Brad,

I disagree with the change.

1) kwsys's hash map stuff is not tested and is not portable.
2) itk's hash map stuff was tested and was portable.
3) the change over to the kwsys hash map stuff has been failing since July
13 and I see no positive gain from the change other than removing the vnl
hash map stuff.

Bill

The errors follow:
[ 28%] Building CXX object Modules/Core/Common/src/
CMakeFiles/ITKCommon.dir/itkE
quivalencyTable.cxx.obj
In file included from
C:/lorensen/ProjectsGIT/ITKModular-mingw/Modules/ThirdPart
y/KWSys/src/itksys/hash_map.hxx:41:0,
                 from
C:/lorensen/ProjectsGIT/ITKModular/Modules/Core/Common/inc
lude/itkEquivalencyTable.h:26,
                 from
C:\lorensen\ProjectsGIT\ITKModular\Modules\Core\Common\src
\itkEquivalencyTable.cxx:18:
C:/lorensen/ProjectsGIT/ITKModular-mingw/Modules/ThirdParty/KWSys/src/itksys/has
h_fun.hxx:127:8: error: redefinition of 'struct itksys::hash<long long int>'
C:/lorensen/ProjectsGIT/ITKModular-mingw/Modules/ThirdParty/KWSys/src/itksys/has
h_fun.hxx:115:24: error: previous definition of 'struct itksys::hash<long
long i
nt>'
C:/lorensen/ProjectsGIT/ITKModular-mingw/Modules/ThirdParty/KWSys/src/itksys/has
h_fun.hxx:131:8: error: redefinition of 'struct itksys::hash<long long
unsigned
int>'
C:/lorensen/ProjectsGIT/ITKModular-mingw/Modules/ThirdParty/KWSys/src/itksys/has
h_fun.hxx:120:33: error: previous definition of 'struct itksys::hash<long
long u
nsigned int>'
make[2]: ***
[Modules/Core/Common/src/CMakeFiles/ITKCommon.dir/itkEquivalencyTab
le.cxx.obj] Error 1
make[1]: *** [Modules/Core/Common/src/CMakeFiles/ITKCommon.dir/all] Error 2
make: *** [all] Error 2

On Tue, Aug 9, 2011 at 12:23 PM, Bradley Lowekamp <brad at lowekamp.net> wrote:

> Bill,
>
> What is the compilation error on mingw? Please don't let my ineptitude with
> VS be an indication of the actual complexity of this problem. It was really
> simple and only my difficulties with VS made it take me so long to fix.
>
> There were problems with the old itk hash maps  as well.  They did not
> support the __int64 or long long types robustly. They only add-hoc-ly
> support ed size_t for win64, there are other combinations of itk
> configurations which would result in similar compilation errors.
>
> Please don't let us move backwards and also have duplicate code in ITK.
> Please do a comparison between the two versions of code, they are 99% the
> same!
>
> Brad
>
> Brad
>
> On Aug 9, 2011, at 9:17 AM, Bill Lorensen wrote:
>
> The only problem I have is that the kwsys change to the hash map code does
> not compile under mingw..
>
> This is not  a show stopper however.
>
> I do plan to revert ITK to the itk hash map stuff, but I'm not sure when
> I'll get to it. Tagging is a good idea.
>
> Bill
>
> On Tue, Aug 9, 2011 at 12:09 PM, Johnson, Hans J <hans-johnson at uiowa.edu>wrote:
>
>>  I am also supportive of making this alpha tag.  It will allow us to move
>> some other projects forward.
>>
>>
>>
>>   From: Bradley Lowekamp <brad at lowekamp.net>
>> Date: Tue, 9 Aug 2011 08:43:10 -0700
>> To: ITK <insight-developers at itk.org>
>> Cc: Hans Johnson <hans-johnson at uiowa.edu>
>> Subject: Alpha 09 tagging
>>
>>   Hello,
>>
>>  I don't think we have tagged the alpha 09 yet.
>>
>>  I think last night's dashboard was better then Fridays because is has
>> the fix for win64 64-bitID an WrapITK worked as well.  This is the version I
>> would like to use with SimpleITK right now. If there is not tag, I can just
>> as easily set SimpleITK to use the hash.
>>
>>  Thanks,
>> Brad
>>
>>  ========================================================
>> Bradley Lowekamp
>> Lockheed Martin Contractor for
>> Office of High Performance Computing and Communications
>> National Library of Medicine
>> blowekamp at mail.nih.gov
>>
>>
>>
>> ------------------------------
>> Notice: This UI Health Care e-mail (including attachments) is covered by
>> the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is
>> confidential and may be legally privileged.  If you are not the intended
>> recipient, you are hereby notified that any retention, dissemination,
>> distribution, or copying of this communication is strictly prohibited.
>> Please reply to the sender that you have received the message in error, then
>> delete it.  Thank you.
>> ------------------------------
>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
> The rrors follow:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20110809/8c9e8149/attachment.htm>