[Insight-developers] KWStyle not run when adding a file in git?

[Alexandre GOUAILLARD]

gaetan,

things were pushed in the repository before the hook was in place.
As a result, there are a lot of stuff in the repository right now that
will fail if you fetch them then try to push them back, even with
minimal modifications. Thi sis exactly what you are experiencing now.

this is to be expected.

alex.



On Wed, Oct 27, 2010 at 1:47 AM, Matthew McCormick (thewtex)
<matt at mmmccormick.com> wrote:
> 2010/10/26 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>
>> Le 26 oct. 10 à 19:37, Matthew McCormick (thewtex) a écrit :
>>
>>> 2010/10/25 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>>>
>>>> Le 25 oct. 10 à 04:20, Matthew McCormick (thewtex) a écrit :
>>>>
>>>>> Hi Gaetan,
>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> I had to fix a set of new files because of missing copyright headers
>>>>>>> today.
>>>>>>> When I tried to commit my changes, KWStyle blocked me because of some
>>>>>>> non
>>>>>>> aligned typedefs and things of that kind.
>>>>>>> Shouldn't they have been detected first when I have added them in the
>>>>>>> repository?
>>>>>>>
>>>>>
>>>>> Thanks for reporting this and your supposition is correct.  However, I
>>>>> cannot reproduce this behavior.  Can you please try again and send a
>>>>> problem file along with its path in its tree.
>>>>>
>>>>
>>>> If you look in my patch "pad by 1 by default in
>>>> ObjectByObjectLabelMapFilter", 619bf1ae54af37cdf314884bce46bbd0477ef6a4,
>>>> you
>>>> can see that the Self typedef was misaligned in
>>>> Code/Review/itkObjectByObjectLabelMapFilter.h. The alignment has been
>>>> fixed
>>>> in that patch, but should have been detected earlier, during the addition
>>>> of
>>>> the file in git.
>>>>
>>>
>>> Here is what I did, but it detects the bug in the first commit.  Maybe
>>> you had the hook temporarily turned off?
>>
>>
>> maybe... but I thought this kind of hook are also applied on the itk
>> repository during the push.
>> If that's the case, the commits should have been rejected on itk.org, right?
>>
>
> As far as I know, that hook does not live on the server, but it seems
> like a good idea.  Brad King or one of the admins would be the ones
> that can set that up.
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>