[Insight-developers] KWStyle not run when adding a file in git?

[Matthew McCormick (thewtex)]

2010/10/26 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>
> Le 26 oct. 10 à 19:37, Matthew McCormick (thewtex) a écrit :
>
>> 2010/10/25 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>:
>>>
>>> Le 25 oct. 10 à 04:20, Matthew McCormick (thewtex) a écrit :
>>>
>>>> Hi Gaetan,
>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I had to fix a set of new files because of missing copyright headers
>>>>>> today.
>>>>>> When I tried to commit my changes, KWStyle blocked me because of some
>>>>>> non
>>>>>> aligned typedefs and things of that kind.
>>>>>> Shouldn't they have been detected first when I have added them in the
>>>>>> repository?
>>>>>>
>>>>
>>>> Thanks for reporting this and your supposition is correct.  However, I
>>>> cannot reproduce this behavior.  Can you please try again and send a
>>>> problem file along with its path in its tree.
>>>>
>>>
>>> If you look in my patch "pad by 1 by default in
>>> ObjectByObjectLabelMapFilter", 619bf1ae54af37cdf314884bce46bbd0477ef6a4,
>>> you
>>> can see that the Self typedef was misaligned in
>>> Code/Review/itkObjectByObjectLabelMapFilter.h. The alignment has been
>>> fixed
>>> in that patch, but should have been detected earlier, during the addition
>>> of
>>> the file in git.
>>>
>>
>> Here is what I did, but it detects the bug in the first commit.  Maybe
>> you had the hook temporarily turned off?
>
>
> maybe... but I thought this kind of hook are also applied on the itk
> repository during the push.
> If that's the case, the commits should have been rejected on itk.org, right?
>

As far as I know, that hook does not live on the server, but it seems
like a good idea.  Brad King or one of the admins would be the ones
that can set that up.