[Insight-developers] Bug fix to itkAutoCropLabelMapFilter

[Navneeth Subramanian]

Hi Gaetan, Luis,
See below:

2010/7/7 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>

>
>
> * there is no need for the GetCropRegion() in AutoCropLabelMapFilter,
> because the GetRegion() from the superclass already return the exact same
> region. I've removed that new method from the code - please let me know if
> there is something I've missed.
>

I agree. Overlooked this.


> * what would you think of implementing the GetMinIndex() and GetMaxIndex()
> method in a more widely used class, namely itk::ImageRegion? I think there
> is a need for these methods in other cases than in AutoCropLabelMapFilter,
> so the change can be more useful implemented directly in that class.
>

Sure. My first assessment is that perhaps
1. GetMinimumIndex()  => would be the same as GetIndex() ?
2. GetMaximumIndex() => would be GetIndex()[Dimension] +
GetSize()[Dimension] ?

Pl let me know If my understanding  is correct & I can implement & commit
the method.

thanks,
navneeth
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100714/5738b0bc/attachment.htm>