[Insight-developers] Bug fix to itkAutoCropLabelMapFilter

[Luis Ibanez]

A minor comment:

As a matter of coding style, the methods:

         GetMinIndex()
         GetMaxIndex()

should be called

         GetMinimumIndex()
         GetMaximumIndex();



    Luis


-------------------------------------------------------
2010/7/7 Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr>

>
> Le 18 juin 10 à 17:13, Navneeth Subramanian a écrit :
>
>  Hello,
>>
>>
> Hi Navneeth,
>
> First, thanks for your contribution, and sorry for the late reply - I only
> find some time now to look at your fix.
>
> I have one comment and one question :
>
> * there is no need for the GetCropRegion() in AutoCropLabelMapFilter,
> because the GetRegion() from the superclass already return the exact same
> region. I've removed that new method from the code - please let me know if
> there is something I've missed.
>
> * what would you think of implementing the GetMinIndex() and GetMaxIndex()
> method in a more widely used class, namely itk::ImageRegion? I think there
> is a need for these methods in other cases than in AutoCropLabelMapFilter,
> so the change can be more useful implemented directly in that class.
>
> Regards,
>
> Gaëtan
>
>  I just made my first commit to ITK, to fix a request to
>> itkAutoCropLabelMapFilter. Specifically, I've added Get functions to access
>> the calculated crop region.
>> See:
>>
>>
>> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Review/itkAutoCropLabelMapFilter.txx?sortby=date&root=Insight&view=diff&r1=text&tr1=1.4&r2=text&tr2=1.3&diff_format=h
>>
>> http://www.itk.org/cgi-bin/viewcvs.cgi/Code/Review/itkAutoCropLabelMapFilter.h?sortby=date&root=Insight&view=diff&r1=text&tr1=1.3&r2=text&tr2=1.2&diff_format=h
>>
>> This is in response to id: 0010513 in mantis.
>>
>> regards,
>> navneeth
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Kitware offers ITK Training Courses, for more information visit:
>> http://kitware.com/products/protraining.html
>>
>> Please keep messages on-topic and check the ITK FAQ at:
>> http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>
> --
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.itk.org
> http://www.mandriva.org  http://www.bepo.fr
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20100713/3269643e/attachment.htm>