[Insight-developers] FloatingPointExceptions and failed tests in Mac

[Hans Johnson]

Luis,

I don¹t think there are special flags required.  There are flags that can
change the behavior of how floating point exceptions behave, but these are
usually things that simply ignore exceptions, or allow undefined behavior in
order to get speed increases.

My gut feeling is that we should spend a little more time verifying that the
floating point report can not be made cleaner by fortifying the code (rather
than changing what is reported).

Kent is on vacation until after the first of the year, so perhaps we should
dis-able this for the next 2 weeks and then take this back up in January.

Hans

Hans
-- 
Hans J. Johnson, Ph.D.
Hans-johnson at uiowa.edu

278 GH
The University of Iowa
Iowa City, IA 52241
(319) 353 8587



From: Luis Ibanez <luis.ibanez at kitware.com>
Date: Sat, 18 Dec 2010 19:01:40 -0500
To: Bill Lorensen <bill.lorensen at gmail.com>
Cc: Hans Johnson <hans-johnson at uiowa.edu>, ITK <insight-developers at itk.org>,
Kent Williams <norman-k-williams at uiowa.edu>
Subject: Re: [Insight-developers] FloatingPointExceptions and failed tests
in Mac

Hi Bill,

Yes, that's the flag that I have ON in thurmite.kitware.

I may have misunderstood Hans, but I thought that
he was implying that an additional set of compilation
options will make this flag to work correctly in the mac.

Currently this build is reporting

19 failing tests in Debug
http://www.cdash.org/CDash/buildSummary.php?buildid=804592

and

139 failing tests in Release:
http://www.cdash.org/CDash/buildSummary.php?buildid=804592


     Luis


----------------------
On Fri, Dec 17, 2010 at 5:05 PM, Bill Lorensen <bill.lorensen at gmail.com>
wrote:
> //Enable Floating Point Exceptions for Testing
> ITK_USE_FLOATINGPOINTEXCEPTIONS:BOOL=ON
> 
> 
> On Fri, Dec 17, 2010 at 5:04 PM, Luis Ibanez <luis.ibanez at kitware.com> wrote:
>> > Hi Hans,
>> >
>> > What compilation options should I use in Mac in order
>> > to get the floating point exceptions to work ?
>> >
>> > I'll add them to the ctest script for thurmite.kitware.
>> >
>> >
>> >      Luis
>> >
>> >
>> > --------------------------------------------
>> > On Fri, Dec 17, 2010 at 11:15 AM, Hans Johnson <hans-johnson at uiowa.edu>
>> > wrote:
>>> >>
>>> >> Luis,
>>> >>
>>> >> Let¹s not rule out the possibility that a different set of floating point
>>> >> exceptions ARE Working on mac with the compile options.  So far the
>>> reported
>>> >> errors have identified real problems in ITK.
>>> >>
>>> >> Hans
>>> >>
>>> >>
>>> >>
>>> >> On 12/17/10 10:11 AM, "Luis Ibanez" <luis.ibanez at kitware.com> wrote:
>>> >>
>>> >>
>>> >> Kent, Hans, Brad,
>>> >>
>>> >> Looking closer at the tests that are failing in thurmite.kitware (a Mac
>>> >> mini):
>>> >>
>>> >> In Debug mode: 19 failing tests:
>>> >> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=803613
>>> >>
>>> >> and in Release mode, 139 failing tests:
>>> >> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=802532
>>> >>
>>> >>
>>> >> They turned out to be related to the fact that this build has ON the
>>> flag:
>>> >>
>>> >>                   ITK_USE_FLOATINGPOINTEXCEPTIONS
>>> >>
>>> >> When I turn the flag OFF, the build returns with only 6 tests failing:
>>> >> http://www.cdash.org/CDash/viewTest.php?onlyfailed&buildid=803142
>>> >>
>>> >>
>>> >> Are you aware of any reason why the floating point exceptions
>>> >> shouldn't  work in a Mac ?
>>> >>
>>> >> and if so, ...
>>> >> should we add some logic in the CMakeLists.txt file to
>>> >> hide this flag when configuring in macs ?
>>> >>
>>> >>
>>> >>
>>> >>      Thanks
>>> >>
>>> >>
>>> >>            Luis
>>> >>
>>> >>
>>> >>
>> >
>> >
>> > _______________________________________________
>> > Powered by www.kitware.com <http://www.kitware.com>
>> >
>> > Visit other Kitware open-source projects at
>> > http://www.kitware.com/opensource/opensource.html
>> >
>> > Kitware offers ITK Training Courses, for more information visit:
>> > http://kitware.com/products/protraining.html
>> >
>> > Please keep messages on-topic and check the ITK FAQ at:
>> > http://www.itk.org/Wiki/ITK_FAQ
>> >
>> > Follow this link to subscribe/unsubscribe:
>> > http://www.itk.org/mailman/listinfo/insight-developers
>> >
>> >



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101219/c511f770/attachment.htm>