[Insight-developers] Pushing to the same Gerrit patch number

[David Cole]

On Fri, Dec 17, 2010 at 11:18 AM, David Doria <daviddoria at gmail.com> wrote:

> If you have the Gerrit local hook on it will insert a Change-Id: line
>>  as the final line of your commit message. If you then edit that
>> commit, amend, interactive rebase etc, and push again, this will show
>> up as patch set 2, 3, and so on assuming you do not change the
>> change-id line, or add lines after it.
>>
>> If you just make another commit, then it will show up as another
>> commit with a unique change-id.
>>
>> Marcus
>>
>
> Is the "Gerrit local hook" enabled by running "SetupForDevelopment.sh"?
> Assuming it was when you did the first commit, then do you still have to do
> the commit,amend,rebase, etc? (or is all that stuff to "fix it" if you
> didn't have it turned on?)
>
> Should this:
>
> git clone ...
> ./Utilities/SetupForDevelopment.sh
> git checkout -b MyBranch
> make some changes
> git add files
> git commit
> git gerrit-push
> make more changes
> git add files
> git commit
> git gerrit-push
>
> result in one Gerrit patch or two?
>
> Thanks,
>
> David
>
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://kitware.com/products/protraining.html
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers
>
>
That results in 2 because it's 2 git commits.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20101217/79419bf4/attachment.htm>