[Insight-developers] Warnings on gelas.megason-lab.hms

[Arnaud Gelas]

Wes,

I have just checked...
I forgot to change in the file that I use with cron :-/...

Arnaud

Wes Turner wrote:
> Arnaud,
>
> The -wshadow option is still showing up on gelas.megason-lab.hms ... 
> does the cache need to be cleared?
>
> - Wes
>
> On Mon, May 18, 2009 at 12:40 PM, Bill Lorensen 
> <bill.lorensen at gmail.com <mailto:bill.lorensen at gmail.com>> wrote:
>
>     They should be CMAKE_CXX_FLAGS, not CMAKE_C_FLAGS.
>
>     On Mon, May 18, 2009 at 11:15 AM, Arnaud Gelas
>     <arnaud_gelas at hms.harvard.edu
>     <mailto:arnaud_gelas at hms.harvard.edu>> wrote:
>     > Hi Wes,
>     >
>     > You're right, this is one of my machine. I can remove -Wshadow
>     flag (no
>     > problem, will be done for next nightly build)!
>     > Note I have been asked couple of days ago to add these following
>     flags for
>     > compilation:
>     >
>     > -Wall -Wextra -Wformat=2 -Wno-format-nonliteral -Wunused
>     > -Wpointer-arith -Winvalid-pch -Wcast-align -Wdisabled-optimization
>     > -Woverloaded-virtual -Wshadow -Wwrite-strings -Wstrict-null-sentinel
>     >
>     > I had to add -funit-at-a-time to remove error messages from gcc...
>     >
>     > Would it be possible to agree on the right flags to be used with
>     gcc 4.3.2
>     > (and other compiler) for nightly builds?
>     >
>     > I have just started a wiki page for this issue:
>     > http://www.vtk.org/Wiki/Build_Instructions_for_Developers
>     >
>     > Arnaud
>     >
>     > Wes Turner wrote:
>     >>
>     >> Arnaud,
>     >>
>     >> We think this is one of your machines.  It is showing 587 compiler
>     >> warnings on the latest nightly.  We think these are do to the
>     -Wshadow
>     >> flag on the build, seemingly due to the shadowing of global
>     variables
>     >> by local variables of the same name in the itkjpeg package.  After
>     >> taking a look at the warnings, it doesn't look like these are real
>     >> code deficiencies.  They seem more like poor coding style.
>      Would you
>     >> be able to remove the flag on the nightly submission, and maybe
>     move
>     >> it to an experimental?  Alternately, if you would like to fix the
>     >> warnings, we would welcome the fixes.
>     >>
>     >> Thanks!
>     >>
>     >> - Wes
>     >>
>     >>
>     >
>     > _______________________________________________
>     > Powered by www.kitware.com <http://www.kitware.com>
>     >
>     > Visit other Kitware open-source projects at
>     > http://www.kitware.com/opensource/opensource.html
>     >
>     > Please keep messages on-topic and check the ITK FAQ at:
>     > http://www.itk.org/Wiki/ITK_FAQ
>     >
>     > Follow this link to subscribe/unsubscribe:
>     > http://www.itk.org/mailman/listinfo/insight-developers
>     >
>
>
>
>
> -- 
> Wesley D. Turner, Ph.D.
> Kitware, Inc.
> R&D Engineer
> 28 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-371-3971 x120