[Insight-developers] Moving Insight Journal Paper 176

[Gaëtan Lehmann]

Hi Wes,

I would continue with BinaryImageToLabelMapFilter and  
LabelMapToBinaryImageFilter, the filters for conversion from/to binary  
images. The API is quite simple, but the code is more complex in  
BinaryImageToLabelMapFilter than in the othe similar filters, because  
it has find the connected components.

Also, I've just fixed a bug in BinaryImageToLabelMapFilter when the  
number of threads is greater then the size on one of the image  
dimesion, so you should get the last version from the website.

Then I would go with the simple filters for label manipulation:

AggregateLabelMapFilter
ChangeLabelLabelMapFilter
MergeLabelMapFilter
PackLabelMapFilter
ShiftScaleLabelMapFilter

And the one to manipulate the region:

AutoCropLabelMapFilter
ChangeRegionLabelMapFilter
CropLabelMapFilter
PadLabelMapFilter
RegionFromReferenceLabelMapFilter

Thanks for the nice work you're doing!

Gaëtan



Le 14 mai 09 à 21:38, Wes Turner a écrit :

> Gaetan,
>
> I have all the classes included in your previous email:
>
>
>  itk::LabelObjectLine
>  itk::LabelObject
>  itk::LabelMap
>  itk::LabelImageToLabelMapImageFilter
>  itk::LabelMapToLabelImageFilter
>
> as well as itk::LabelMapFilter (needed for  
> itk::LabelMapToLabelImageFilter) and  
> itk::Functor::LabelObjectLineComparator (derived by stripping out  
> the functor from itk::LabelObjectLine).
>
> I'm not sure how much more time I will have before the code freeze,  
> but if you have any more high priority suggestions, I would be happy  
> to hear them.
>
> - Wes
>
>
> On Thu, May 14, 2009 at 11:15 AM, Wes Turner  
> <wes.turner at kitware.com> wrote:
> Thanks, Gaetan, there is a lot of code in that submission and you  
> will notice it going into the repository ... slowly ...  haven't  
> taken a close look at your patches yet, but thanks for sending them  
> on.
>
> - Wes
>
>
> On Tue, May 12, 2009 at 3:25 PM, Gaëtan Lehmann <gaetan.lehmann at jouy.inra.fr 
> > wrote:
>
> Le 12 mai 09 à 15:08, Gaëtan Lehmann a écrit :
>
>
> Two quick issues.
>
>      • If we try to configure the system with CMAKE_BUILD_TYPE set  
> to Release, the compiler crashes (error message is below).  System  
> is Ubuntu, gcc-4.2.4 oor 4.3.2.
>
> I had this kind of problem on mandriva 2009.0 rc1 last year. A  
> compiler upgrade fixed the problem.
> Now that I see that code, it recall me that et should be moved to an  
> helper function, because, IIRC, msvc 6 doesn't like too much the  
> templated method. This small change may help with your compiler  
> issue as well :-)
>
> It's not clear.  Is this something you can help with, or are you  
> proposing that I move this out?
>
> I can't help with the compiler issue.
> But the method where your compiler fail needs a small refactoring to  
> build with older compilers. This refactoring may help with the  
> compiler crash you're experimenting.
>
> I hope that's much clear.
>
> Hi,
>
> I've implemented the helper function for a new class. There is no  
> templated method in:
>
>  http://voxel.jouy.inra.fr/darcs/contrib-itk/binaryAttributeMorphology/itkShapeUniqueLabelMapFilter.txx
>
> Instead I've used a templated function in
>
>  http://voxel.jouy.inra.fr/darcs/contrib-itk/binaryAttributeMorphology/itkLabelMapUtilities.h
>
> I guess that's better for msvc 6 compatibility, and maybe for Wes'  
> compiler issue.
> I'd be happy to get some comments on this way of implementing things.
>
>
> Gaëtan
>
>
> -- 
> Gaëtan Lehmann
> Biologie du Développement et de la Reproduction
> INRA de Jouy-en-Josas (France)
> tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
> http://voxel.jouy.inra.fr  http://www.mandriva.org
> http://www.itk.org  http://www.clavier-dvorak.org
>
>
>
>
> -- 
> Wesley D. Turner, Ph.D.
> Kitware, Inc.
> R&D Engineer
> 28 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-371-3971 x120
>
>
>
> -- 
> Wesley D. Turner, Ph.D.
> Kitware, Inc.
> R&D Engineer
> 28 Corporate Drive
> Clifton Park, NY 12065-8662
> Phone: 518-371-3971 x120

-- 
Gaëtan Lehmann
Biologie du Développement et de la Reproduction
INRA de Jouy-en-Josas (France)
tel: +33 1 34 65 29 66    fax: 01 34 65 29 09
http://voxel.jouy.inra.fr  http://www.mandriva.org
http://www.itk.org  http://www.clavier-dvorak.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: PGP.sig
Type: application/pgp-signature
Size: 203 bytes
Desc: Ceci est une signature ?lectronique PGP
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090516/bb79d293/attachment.pgp>