[Insight-developers] Incorporating the new statistics framework in ITK

[Bradley Lowekamp]

I am not sure I am in favor of the name change, but if I was  
considering an alternative name HistogramSample would be my first  
thought.

However changing this class's name would also make the name of the  
Histogram filters less intuitive, and complicate their compliance with  
ITK naming conventions.

Brad


On May 11, 2009, at 3:00 PM, Stephen Aylward wrote:

> Why the name MeasurementHistogram?
>
> The name tells me nothing about how this class is different from
> itkHistogram...I can see this leading to much confusion.
>
> What is the difference in the classes...the name should reflect it...
>
> s
>
>
>
> On Sun, May 10, 2009 at 1:27 PM, Bill Lorensen <bill.lorensen at gmail.com 
> > wrote:
>> Here is a note I sent a while ago:
>>
>> If Histogram were called MeasurmentHistogram, I might be able to make
>> a backward compatible itkHistogram that uses the new
>> MeasurmentHistogram. Currently, the new Histogram has
>> changed the template arguments from the old. Actually it matches
>> exactly itkVariableDimensionHistogram, but that is not such a great
>> name for the new Statistics.
>>
>>
>> On Sun, May 10, 2009 at 12:26 PM, Karthik Krishnan
>> <karthik.krishnan at kitware.com> wrote:
>>> Hello:
>>>
>>> The refactored framework has been checked into Code/Review/ 
>>> Statistics/ .
>>>
>>> The default is to build using the old framework. The new framework  
>>> is used
>>> instead when ITK_USE_REVIEW and ITK_USE_REVIEW_STATISTICS are  
>>> turned ON.
>>>
>>> Filters using the statistics classes (in Algorithms, BasicFilters  
>>> etc) and
>>> their associated examples and tests have been fixed to work with  
>>> both the
>>> old and the new. You will find ifdefs in the code for this purpose.
>>>
>>> Examples/Statistics are disabled when using the refactored  
>>> framework. This
>>> is due to the fact that we will be including the refactored  
>>> statistics
>>> library when we update the SoftwareGuide the next time and hence  
>>> we'd be
>>> writing a parallel Examples directory. We are not going to have  
>>> the guide
>>> telling users how to use to older framework.
>>>
>>> There are two parallel testing trees.
>>>      Testing/Code/Numerics/Statistics - Old framework
>>>      Testing/Code/Review/Statistics - New framework
>>>
>>> InsightApplications/ has been fixed to work with the old and the new
>>> frameworks. We had to disable an application :
>>> GaussianMinimumErrorClassifier since we had not implemented a few  
>>> filters in
>>> the new framework.
>>>
>>> isengard, zion and redwall submit nightly builds using the new  
>>> framework.
>>>
>>> As a reminder, please refrain from making changes to
>>> NAMICSandbox/ITKStatisticsPipelineRefactoring, since we are going  
>>> to ignore
>>> this repository. It has found a new life inside ITK now.
>>>
>>> Thanks
>>> --
>>> karthik
>>>
>>> On Tue, Apr 28, 2009 at 6:03 PM, Karthik Krishnan
>>> <karthik.krishnan at kitware.com> wrote:
>>>>
>>>> Hello:
>>>>
>>>> I'd like to bring the refactored statistics framework into ITK.  
>>>> To do that
>>>> I'd like to propose the following changes. I'd like to push them  
>>>> into ITK
>>>> towards the end of the week Friday-Sunday, when dashboard hiccups  
>>>> would have
>>>> the least impact.
>>>>
>>>> - Bring the new framework into Code/Review/StatisticsV2
>>>>
>>>> - Add a CMake var ITK_USE_NEW_STATISTICS_FRAMEWORK, (OFF by  
>>>> default)
>>>>
>>>> - Update itkConfigure.h.in, itkIncludeDirectories.cmake to pick  
>>>> the right
>>>> things.
>>>>
>>>> - Progressively update code/tests from Algorithms/BasicFilters to  
>>>> compile
>>>> with the old and new framework.
>>>>
>>>> - Setup a couple of dashboards that to compile with the new  
>>>> framework to
>>>> monitor progress.
>>>>
>>>> - Cleanup tests / errors
>>>>
>>>>
>>>> More on the wiki at :
>>>> http://itk.org/Wiki/Proposals:Refactoring_Statistics_Framework_2007
>>>>
>>>>
>>>> Any thoughts ?
>>>>
>>>> Thanks
>>>>
>>>> --
>>>> karthik
>>>
>>>
>>> _______________________________________________
>>> Powered by www.kitware.com
>>>
>>> Visit other Kitware open-source projects at
>>> http://www.kitware.com/opensource/opensource.html
>>>
>>> Please keep messages on-topic and check the ITK FAQ at:
>>> http://www.itk.org/Wiki/ITK_FAQ
>>>
>>> Follow this link to subscribe/unsubscribe:
>>> http://www.itk.org/mailman/listinfo/insight-developers
>>>
>>>
>> _______________________________________________
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.itk.org/mailman/listinfo/insight-developers
>>
>
>
>
> -- 
> Stephen R. Aylward, Ph.D.
> Director of Medical Imaging
> Kitware, Inc. - North Carolina Office
> http://www.kitware.com
> (518) 371-3971 x300
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the ITK FAQ at: http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-developers

========================================================
Bradley Lowekamp
Lockheed Martin Contractor for
Office of High Performance Computing and Communications
National Library of Medicine
blowekamp at mail.nih.gov


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.itk.org/mailman/private/insight-developers/attachments/20090511/630f4f26/attachment.htm>