[Insight-developers] Problems with LightObject checkin

[Bill Lorensen]

Tom,

Sounds like your fix is cleaner. Go ahead and check it in.

Thanks,

Bill

On Wed, May 14, 2008 at 12:51 PM, Tom Vercauteren
<tom.vercauteren at m4x.org> wrote:
> Bill,
>
> I finally managed to get my hands on a cygwin machine. Including
> Windows.h in itkLightObject.h instead of in itkLightObject.cxx seems
> to work...
>
> With this fix we would't need to check whether we use cygwin or not
> and would use windows atomic operations rather than the ones from gcc.
> Would you like me to commit my fix or should I leave it as is?
>
> Tom
>
> On Wed, May 14, 2008 at 6:41 PM, Bill Lorensen <bill.lorensen at gmail.com> wrote:
>> Tom,
>>
>>  I just checked in a cygwin fix.
>>
>>  Bill
>>
>>
>>
>>  On Wed, May 14, 2008 at 12:08 PM, Sean McBride <sean at rogue-research.com> wrote:
>>  > On 5/14/08 5:53 PM, Tom Vercauteren said:
>>  >
>>  >>Thanks a lot Sean. The fix seems good to me.
>>  >>
>>  >>I actually copied your code from itkTimeStamp but apparently missed an
>>  >>include...
>>  >
>>  > I noticed.  The difference with that class is that:
>>  >
>>  >  unsigned long m_ModifiedTime;
>>  >
>>  > is always 'unsigned long' so the include was not needed in the .h.  I
>>  > didn't change its size since the public GetMTime() returns 'unsigned
>>  > long'.  On the Mac, long changes sizes between the 32 and 64 bit ABIs,
>>  > which is why I needed all the #if __LP64__ stuff.  For itkLightObject
>>  > you could have chosen to use int32_t on both 32 and 64 bit, but I guess
>>  > a bigger value is nicer to reduce the chance of wrap around.
>>  >
>>  > --
>>  > ____________________________________________________________
>>  > Sean McBride, B. Eng                 sean at rogue-research.com
>>  > Rogue Research                        www.rogue-research.com
>>  > Mac Software Developer              Montréal, Québec, Canada
>>  >
>>  > _______________________________________________
>>  > Insight-developers mailing list
>>  > Insight-developers at itk.org
>>  > http://www.itk.org/mailman/listinfo/insight-developers
>>  >
>>
>