[Insight-developers] Request for testing help: itkImageIOBase.cxx

[Kent Williams]

Offsets are handled separately because they were in the original code, 
whose structured was dictated by the nesting level limit in Visual C++. 
Also the ComponentType is known already.

We all have better things to do than to optimize this, given that it 
works and it's called precisely once per image read/write . It  also has 
the advantage of being excruciatingly human-readable,


Miller, James V (GE, Research) wrote:

>Kent,
>
>It compiles fine for me on Visual Studio .NET 2003 (7.1).
>
>Don't know about Borland or VS7 or VS6.
>
>Looking at it SetPixelTypeInfo() method, why is Offset handled separately from
>the other pixel type?  
>
>Another minor point is that the function name is itkCheckPType(). I would call 
>itkSetPixelType() since it actually "sets" the pixel type information 
>and returns false if it cannot.
>
>As for performance, this code is not call very frequently, so I wouldn't worry 
>about it.
>
>Finally, the Dashboard is all red.  You might want to wait to check it in.
>
>Jim
>
>
>  
>