[Insight-developers] Const-correctness in ChangeLabelImageFilter.h

[Luis Ibanez]

Hi Zach,

Committing minor fixes is perfectly fine, in particular
when you log a bug entry related to them. This is very
helpful to the developers team and we appreciate a lot
your contributions to the toolkit.


As long as you run an Experimental build before you
commit your changes, everything should go smoothly,
because in an Experimental build you will have the
opportunity to find whether a change is actually
affecting other sections of the toolkit (which is
usually the case).



In the particular case of this SetChangeMap() method,
I wonder if we should actually use the "itkSetMacro()"...


In this way we will get also the call for the internal
itkDebugMacro(), and the call to "Modified()". You may
want to give it a try to the SetMacro() first.




    Thanks



       Luis



-----------------------
Zachary Pincus wrote:
> Hi folks,
> 
> There's a const-correctness issue  in Insight/Code/BasicFilters/ 
> itkChangeLabelImageFilter.h.
> 
> Specifically, in the utility class ChangeLabel, a method is defined  as 
> follows:
> 
>   void SetChangeMap( ChangeMapType & changeMap )
>   {
>     m_ChangeMap = changeMap;
>   }
> 
> The method signature ought to be:
>   void SetChangeMap( const ChangeMapType & changeMap )
> 
> I presume this fix couldn't possibly cause a problem, so I'll open a  
> bug/commit the fix/close the bug on this tomorrow, barring objections.
> 
> Zach
> 
> (ps - if my emails are getting too frequent for the dev list, someone  
> let me know if there's a subset of folks that I should give a heads  up 
> to before committing minor changes like this.)
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
> 
>