[Insight-developers] Interface Mismatch !
Ashish Poddar
ahpoddar at gmail.com
Wed Jun 8 21:40:59 EDT 2005
Hi,
Actually while experimenting with the two, I also observed one more
thing... The two functions are not exactly same in functionality. because
the centeredAffine transform function rotates about a given center of
rotation, (which is is Rotate3D function), and the SetRotation function of
VersorTransform rotates about the Center of Image, and there is no provision
of rotating about a given point.
with best regards,
Ashish.
On 6/8/05, Stephen R. Aylward <aylward at unc.edu> wrote:
>
> Hi,
>
> An "acceptable" option is to have both functions in both classes. This
> makes the interfaces compatible and doesn't break existing code.
>
> We could then also add a warning to one of those functions (in both
> classes) to indicate that it will be deprecated in a future version. I
> think we should put that warning in the Rotate3D function - it is not
> consistent with the ITK API.
>
> Stephen
>
> Ashish Poddar wrote:
> > Hi,
> > I know this can break quite a lot of existing code, but nevertheless, I
> > think this can be thought about !
> > The interface for VersorTransform is having a function - SetRotation
> with
> > same semantics as the Rotate3D function of CenteredAffineTransform and
> hence
> > I suggest renaming one of them to match the other.
> > regards,
> > Ashish.
> >
> >
> --
> ===========================================================
> Dr. Stephen R. Aylward
> Associate Professor of Radiology
> Adjunct Associate Professor of Computer Science and Surgery
> http://caddlab.rad.unc.edu
> aylward at unc.edu
> (919) 966-9695
>
--
Ashish Poddar
Have an acceptable reason for accepting anything.
Y:ashish_poddar | MSN:ashish_poddar at yahoo.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.itk.org/mailman/private/insight-developers/attachments/20050608/72aebcd7/attachment.html
More information about the Insight-developers
mailing list