[Insight-developers] VXL code modifications

[Brad King]

Julien Jomier wrote:
> I'm almost done porting ITK for MSVC 8 beta 2.
> The only two remaining problems are related to VXL:
> 
> 1) The following line:
> inline static float max() { return 3.40282347E+38F; }
> 
> returns a compiler error because the value is too big.
> Decreasing the value by a small amount works.
> 
> 2) in netlib.h, the following lines:
> #if VXL_C_MATH_HAS_SQRTF
> float sqrtf(float);
> #else
> 
> returns:
> C:\DartClient\Insight\Utilities\vxl\v3p\netlib\netlib.h(25) : error 
> C2059: syntax error : 'type'
> 
> This is not a CMake issue since sqrtf() is defined by the compiler. One 
> possible fix is to comment this line for MSVC 8.
> 
> What do you think?
> 
> Also, is there a way to contribute these modifications back to VXL? Do 
> we have a policy on this?

I have a cvs watch on Utilities/vxl.  Any changes that are committed I 
inspect and port to upstream VXL (to which I have write access).  I 
think someone has already gotten some of VXL working with MSVC 8 so you 
might want to check their code to see if they already fixed these problems.

-Brad