[Insight-developers] itkOrientImageFilter working only in 3D?

[Miller, James V (Research)]

Hey Julien,

The reason for keeping filters templated over image type is for 
consistency.  I think most of our filters are templated over Image type.
If we are consistent, people will be able to "guess" what template
parameters
a filter has.  Most filters have two template parameters, input image type
and output image type.  Usually, the output image type can default to the
input
image type.  There are some cases where there is only a single template
parameter, namely the input image type, because the output image type is
completely defined by the input image type (sometimes the output HAS to be 
same as the input image type, sometimes the output HAS to be unsigned long
with
the same image dimension as the input image type, sometimes the output HAS
to
be a CovariantVector, etc.).

But by an large, I can add a filter to an existing program by guessing there
are two template parameters (and I do not need to refer to the
documentation).

Also, there are several Image classes (Image, ImageAdaptor,  BloxImage).
Any one of these could be the input to the OrientImageFilter.

Jim



-----Original Message-----
From: Julien Jomier [mailto:jjomier at cs.unc.edu]
Sent: Wednesday, October 27, 2004 10:25 AM
To: 'Miller, James V (Research)'; 'Insight Developers List'
Subject: RE: [Insight-developers] itkOrientImageFilter working only in
3D?


Hi Jim,

What is the benefit of ConceptCheck v.s. template parameters?
Some of the classes are using PixelType when they work only for one
dimensionality (HoughTransform filters for instance), should we template
them over the image type and use the notion of concept checking?

Thanks,

Julien

> -----Original Message-----
> From: insight-developers-bounces at itk.org 
> [mailto:insight-developers-bounces at itk.org] On Behalf Of 
> Miller, James V (Research)
> Sent: Wednesday, October 27, 2004 9:54 AM
> To: 'Julien Jomier'; 'Insight Developers List'
> Subject: RE: [Insight-developers] itkOrientImageFilter 
> working only in 3D?
> 
> 
> If it only works in 3D, we should put in a ConceptCheck that 
> it is only
> instantiated with 3D input and 3D output images.  The 
> templating should
> still
> remain over the image types. 
> 
> Jim
> 
> -----Original Message-----
> From: Julien Jomier [mailto:jjomier at cs.unc.edu]
> Sent: Tuesday, October 26, 2004 8:44 PM
> To: 'Insight Developers List'
> Subject: [Insight-developers] itkOrientImageFilter working only in 3D?
> 
> 
> Hi,
> 
> Sorry if this is a naive question.
> It seems that itkOrientImageFilter only works for 3D images. 
> Is this the way
> it should be or is it supposed to work for 2D images too?
> If this filter is restricted to only one dimensionality, 
> would it be better
> to template the filter over the pixel type of the 
> input/output image (output
> type  should be the same as the output)?
> 
> thanks,
> 
> Julien
> 
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
> _______________________________________________
> Insight-developers mailing list
> Insight-developers at itk.org
> http://www.itk.org/mailman/listinfo/insight-developers
>