[Insight-developers] Dashboard / Registration

[Miller, James V (CRD)]

Luis,

The StartOptimization() method of an optimizer (at least the ConjugateGradientOptimizer) takes a
const reference to ParametersType.  However, your tests are passing in a SmartPointer to
ParametersType.  The SmartPointer code will cast down to a raw pointer but I do not think it will
derefence the pointer automatically to produce the reference type needed for StartOptimization().

The tests could be changed from

foo->StartOptimization( initialValue );

to 

foo->StartOptimization( *initialValue );

or the StartOptimization() method could be changed to take a pointer rather than a reference.

Jim


-----Original Message-----
From: Lorensen, William E (CRD) 
Sent: Tuesday, March 27, 2001 7:59 AM
To: 'luis.ibanez@ieee.org'; insight-developers@public.kitware.com
Subject: RE: [Insight-developers] Dashboard / Registration


Luis,
The optimizer classes are not building on the intel compiler.

Could you please correct the ^M problems:
==========================================================
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:117:  /* Initialize Linear part*/ 
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:124:      {
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:125:                m_Parameters[ k++ ] =
0.0;
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:126:      }
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:127:      else 
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:174:
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:190:
Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx:195:  std::cout << std::endl;

Algorithms/itkImageToImageAffineMeanSquaresRegistration.txx has ^M's. They must be removed before you
can commit.
==========================================================
==========================================================
Algorithms/itkImageToImageAffinePatternIntensityRegistration.txx:187:
Algorithms/itkImageToImageAffinePatternIntensityRegistration.txx:193:*/

Algorithms/itkImageToImageAffinePatternIntensityRegistration.txx has ^M's. They must be removed
before you can commit.
==========================================================
==========================================================
BasicFilters/itkGradientRecursiveGaussianImageFilter.txx:109:  {
BasicFilters/itkGradientRecursiveGaussianImageFilter.txx:110:   unsigned int i=0; 
BasicFilters/itkGradientRecursiveGaussianImageFilter.txx:118:      m_SmoothingFilters[ i
]->SetDirection( j );
BasicFilters/itkGradientRecursiveGaussianImageFilter.txx:119:     i++;

BasicFilters/itkGradientRecursiveGaussianImageFilter.txx has ^M's. They must be removed before you
can commit.
==========================================================
==========================================================
Numerics/itkGradientDescentOptimizer.txx:170:  ParametersType newPosition;

Numerics/itkGradientDescentOptimizer.txx has ^M's. They must be removed before you can commit.
==========================================================
esopus:lorensen> ~/dis1/CVSROOT/checkCtrlM */*.h
==========================================================
Algorithms/itkImageToImageAffineMeanSquaresRegistration.h:113:   typedef
GradientDescentOptimizer<MetricType>           OptimizerType;
Algorithms/itkImageToImageAffineMeanSquaresRegistration.h:120:

Algorithms/itkImageToImageAffineMeanSquaresRegistration.h has ^M's. They must be removed before you
can commit.
==========================================================
==========================================================
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:21:#include "itkMultipleValuedNonLinearOptimizer.h"
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:92:
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:94:  /**
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:95:   * MeasureType typedef.
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:96:   */
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:97:  typedef typename TCostFunction::MeasureType
MeasureType;
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:98:
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:99:
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:100:  /**
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:101:   * GradientType typedef.
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:102:   */
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:103:  typedef typename
TCostFunction::DerivativeType      DerivativeType;
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:104:
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:105:
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:215:      {       
Numerics/itkMultipleValuedNonLinearVnlOptimizer.h:218:

Numerics/itkMultipleValuedNonLinearVnlOptimizer.h has ^M's. They must be removed before you can
commit.
==========================================================


-----Original Message-----
From: Luis Ibanez [mailto:ibanez@cs.unc.edu]
Sent: Monday, March 26, 2001 10:16 AM
To: insight-developers@public.kitware.com
Subject: [Insight-developers] Dashboard / Registration


Hi,

We are changing the part of the API in the registration
framework.  Previously a VectorContainer was used to
pass the parameters of the spatial transformation to the
optimizers.  This was impractical because VectorContainer
elements has to be accessed through iterators.

So, now the framework is templated the parameters type,
and it could be any type with the operator[]() defined.

The bad news is that the changes are not completed yet
so there are a lot of new error messages on the dashboard,
coming from these modifications.  We are working now
on fixing them....



Luis




_______________________________________________
Insight-developers mailing list
Insight-developers@public.kitware.com
http://public.kitware.com/mailman/listinfo/insight-developers

_______________________________________________
Insight-developers mailing list
Insight-developers@public.kitware.com
http://public.kitware.com/mailman/listinfo/insight-developers