[Insight-developers] itkBinomialBlurImageFilter

Damion Shelton dmsst59+@pitt.edu
Mon, 16 Jul 2001 17:17:03 -0400


Comments are below... in general I agree with the changes but I do have some
questions/comments.

> I checked in a version of your binomial blur image filter that should work
in the pipeline mechanism.

To my knowledge, it worked in the pipeline before. At least, it supported
chaining with SetInput/GetOutput. What was the problem?

> I added a GenerateInputRequestedRegion() method so that the filter can
request a bigger input than
> its output. Thus, the filter does not have to process the entire image.

This has caused some problems. For an image with dimension n, the output
image dimension is now n + numiterations*2. Although I understand why the
change was made, this causes some problems in assuming that a constant size
image passes through the pipeline (since it's not).

> I also reworked some of the loops and regions so you can avoid calling
GetIndex() and SetPixel() in
> favor of iterator access.

Sounds good.

> Unfortunately, there is no test for this filter.  So I couldn't check my
changes.

That will change soon; converting to itkPoint, combined with the
Scalar/ScalarVector changes have set me back a bit.

> This filter could be made multithreaded very easily.  If you agree with my
changes, then we should
> probably make this a multithreaded filter.

I'll let you know once it's working again.

-Damion-