[IGSTK-Developers] Code Reviews ImageSpatialObject : CTImageSpatialObject : MRImageSpatialObject

[Luis Ibanez]

Hi Rick,

Here are my comments for the code review of the ImageSpatialObject.
and its derived classes.


ImageSpatialObject


* #include igstkMacros not needed.

* Is missing to have the copy constructor and the assignment
   operators to be defined privately and not implemented.

* #include igstkEvents not needed in the .txx, it comes
   from the igstkSpatialObject.

* m_Image member variable was not printed out in PrintSelf().

* Print() was not being invoked in the test.
   This resulted in 50% code coverage.




CTImageSpatialObject

* Missing the copy constructor and assigment
   operators in the private section. They must
   be declared and not instantiated in order to
   enforce the use of SmartPointers.

* Detailed documentation was missing

* "See also" Doxygen keywords were added for
   the CTImageReader and the
   CTSpatialObjectRepresentation classes.



MRImageSpatialObject

* Missing the copy constructor and assigment operators in
   the private section. They must be declared and not
   instantiated in order to enforce the use of SmartPointers.

* Detailed documentation was missing

* "See also" Doxygen keywords were added for the MRImageReader,
    CTImageSpatialObject and the MRSpatialObjectRepresentation classes.

* In the test, the Print() method was not being invoked.
   That affected code coverage.




   Luis