[Ctk-developers] Fwd: [mitk-users] MITK with Latest CTK - problem with DCMTK

Thu May 9 10:22:05 UTC 2013

Hi JC,

Did you have time to have a look at the broken support for the official 
DCMTK snapshot inside CTK? If I remember correctly, we settled on the 
decision to support the latest official DCMTK snapshot together with the 
patched versions of DCMTK contained in the commontk Github repositories 
(eventually by "ifdef"s  in the CTK code).

As Marco pointed out in his E-Mail, it looks like your merge containing 
changes to the FindDCMTK.cmake script broke the support for the DCMTK 
snapshot...

It would be great to solve this issue before the Hackfest.

Thanks,

Sascha

On 04/19/2013 02:40 PM, Jean-Christophe Fillion-Robin wrote:
> Hi Matt,
>
> I don't know which change or who did these changes. But if we can find 
> out, I could provide guidance so that we can add so configure check in 
> order to make the feature introspection of DCMTK robust. That way, we 
> would be able to include / exclude part of the CTKDCMTK library 
> appropriately.
>
> Thanks
> Jc
>
>
> On Fri, Apr 19, 2013 at 2:50 AM, Clarkson, Matt <m.clarkson at ucl.ac.uk 
> <mailto:m.clarkson at ucl.ac.uk>> wrote:
>
>     Hi there CTK-ers,
>
>     please can anyone help me out with a CTK / DCMTK problem?  It
>     looks to me like recent changes to CTK stop CTK working with the
>     official DCMTK snapshots which are used in MITK.
>     Is that right?
>
>     If anyone can shed light on the way forward, Im happy to try and
>     help here.
>
>     Thanks
>
>     Matt
>
>
>     Begin forwarded message:
>
>>     *From: *Marco Nolden <m.nolden at dkfz-heidelberg.de
>>     <mailto:m.nolden at dkfz-heidelberg.de>>
>>     *Subject: **Re: [mitk-users] MITK with Latest CTK - problem with
>>     DCMTK*
>>     *Date: *13 April 2013 22:38:37 BST
>>     *To: *"Clarkson, Matt" <m.clarkson at ucl.ac.uk
>>     <mailto:m.clarkson at ucl.ac.uk>>
>>     *Cc: *mitk-users <mitk-users at lists.sourceforge.net
>>     <mailto:mitk-users at lists.sourceforge.net>>
>>
>>     Hi Matt,
>>
>>     MITK's super build is using dcmtk-3.6.1_20120222, but there is a
>>     newer snapshot here [1] and from a quick look through the Changes
>>     we could upgrade if it compiles with MITK. If you like to try it
>>     you could replace the URL in CMakeExternals/DCMTK.cmake (and
>>     remove or adapt the URL_MD5 line).
>>
>>     I'm not sure though that the CTK change you mention will work
>>     with that snapshot. CTK by default uses a forked version of DCMTK
>>     and there has been some activity lately. IIRC we agreed that CTK
>>     _should_ always build with the official DCMTK snapshots as well,
>>     but I'm afraid that doesn't get tested regularly. So if that is
>>     broken we should contact JC if the changes can be made in a
>>     compatible way.
>>
>>     If you could confirm that MITK builds with the newer snapshot we
>>     could upgrade this on our side. Unfortunately I can't test it
>>     myself at the moment.
>>
>>     Upgrading the CTK version can be more tricky, Sascha could maybe
>>     comment on that. If you are just interested in the slider tick
>>     change, we could also use a special version, did that before.
>>
>>     Best,
>>
>>     Marco
>>
>>     [1]:
>>     http://dicom.offis.de/download/dcmtk/snapshot/dcmtk-3.6.1_20121102.tar.gz
>>
>>
>>
>>     Am 04.04.2013 21:06, schrieb Clarkson, Matt:
>>>     Hi there,
>>>
>>>     Following the merging of CTK issue #313 to CTK master (CTK
>>>     commit 099a88bb24), I then tried to update my MITK to compile
>>>     with this version of CTK, so I could pick up Miklos's new slider
>>>     tick interval.
>>>     However, in the CTK master branch, commit 52d9539f5e, which is 3
>>>     before the latest, causes CTK to not build using the DCMTK
>>>     version that MITK is using.
>>>
>>>     So, it looks to me like MITK will need to consider upgrading
>>>     DCMTK before they can move to the latest CTK, which is the
>>>     reason I post here, instead of the CTK mailing list.
>>>
>>>     However, I don't really understand what the reason for the CTK
>>>     change is, or why CTK has a different fork of DCMTK, or what
>>>     exactly is the version of DCMTK that MITK is using -
>>>     dcmtk-3.6.1_20120222.tar.gz, so Im a bit stuck.
>>>
>>>     Can anyone in MITK-land shed a light on a way forward?
>>>
>>>     Thanks
>>>
>>>     Matt
>>>
>>>
>>>
>>>     ------------------------------------------------------------------------------
>>>     Minimize network downtime and maximize team effectiveness.
>>>     Reduce network management and security costs.Learn how to hire
>>>     the most talented Cisco Certified professionals. Visit the
>>>     Employer Resources Portal
>>>     http://www.cisco.com/web/learning/employer_resources/index.html
>>>     _______________________________________________
>>>     mitk-users mailing list
>>>     mitk-users at lists.sourceforge.net
>>>     <mailto:mitk-users at lists.sourceforge.net>
>>>     https://lists.sourceforge.net/lists/listinfo/mitk-users
>>
>>
>
>
>     _______________________________________________
>     Ctk-developers mailing list
>     Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
>     http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
>
>
> -- 
> +1 919 869 8849

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20130509/70566833/attachment.htm>