[Ctk-developers] Clang and DCMTK

[Steve Pieper]

Big thanks Sascha!

On Sat, May 12, 2012 at 7:46 AM, Sascha Zelzer
<s.zelzer at dkfz-heidelberg.de>wrote:

>  Hi,
>
> just for your information, CTK now (well, since a couple of days) uses the
> DCMTK 3.6.1 snapshot (22/02/2012).
>
> CTK and all its dependencies can now be build with Clang. Additionally,
> the custom DICOM SCU files have been removed from CTK and the CTK DICOM
> library now uses the SCU classes from DCMTK.
>
> Best,
> Sascha
>
>
> On 04/30/2012 07:05 PM, Julien Finet wrote:
>
> If you didn't change from Static to Shared, then no worries, it should be
> fine with Slicer.
> Thanks,
> j.
>
> On Mon, Apr 30, 2012 at 12:47 PM, Sascha Zelzer <
> s.zelzer at dkfz-heidelberg.de> wrote:
>
>>  Hi J2,
>>
>> I'm not sure I fully understand your question. I did not change the build
>> type, DCMTK is still build as a static library (I tried building in shared
>> mode but then some CTK DICOM tests did not run on Linux because the DCMTK
>> command line tools do not contain rpath entries and hence the shared libs
>> were not found).
>>
>> I didn't touch anything "install" related either, everything is as it was
>> before concerning the DCMTK build options (except an added
>> DCMTK_WITH_DOXYGEN:BOOL=OFF and an explicit line for
>> BUILD_SHARED_LIBS:BOOL=OFF which is the default).
>>
>> Thanks for having a look,
>>
>> Sascha
>>
>>
>> On 04/30/2012 05:53 PM, Julien Finet wrote:
>>
>> Hi Sashcha,
>>
>>  Thanks for taking care of it. I've not tried the "install" rules of
>> DCMTK. Do you confirm it works as expected.
>> For Slicer, before we can use DCMTK as shared we need to make sure the
>> Slicer packaging works fine with DCMTK, especially with the Mac fixup :-/
>>
>>  J.
>>
>> On Sun, Apr 29, 2012 at 5:28 AM, Sascha Zelzer <
>> s.zelzer at dkfz-heidelberg.de> wrote:
>>
>>>  Hi Folks,
>>>
>>> I would look to see proper Clang support in CTK (and hence MITK) such
>>> that the native build tools on MacOS can be used (Clang is the default
>>> compiler for XCode).
>>>
>>> It looks like the only show-stopper is the DCMTK version we are using.
>>> This problem has already been identified on the the Slicer mailing list [1]
>>> and I suggest to move forward with Jc's option b)
>>>
>>> Update the sha1 of git.dcmtk.org/dcmtk.git  required to build CTK
>>>
>>>
>>> Using the DCMTK 3.6.1 snapshot [2] would fix the DCMTK Clang issues and
>>> would also fix a few other issues we had in CTK (J2's static initialization
>>> problems and the duplicated DICOM SCU class). You can have a look at the
>>> necessary changes in CTK here:
>>>
>>>
>>> https://github.com/saschazelzer/CTK/compare/master...dcmtk-3.6.1-snapshot-compatibility
>>>
>>> Does anybody have any objections to merging the above branch into CTK
>>> master?
>>>
>>> Thanks,
>>>
>>> Sascha
>>>
>>>
>>> [1]:
>>> http://slicer-devel.65872.n3.nabble.com/DCMTK-clang-compiler-errors-td3811531.html
>>> [2]: http://support.dcmtk.org/wiki/dcmtk/news/start
>>>
>>> _______________________________________________
>>> Ctk-developers mailing list
>>> Ctk-developers at commontk.org
>>> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>>>
>>>
>>
>>
>
>
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20120512/ada6a074/attachment.html>