[Ctk-developers] CTK, DCMTK and Debian
Marco Nolden
m.nolden at dkfz-heidelberg.de
Thu Dec 20 11:47:28 EST 2012
On 12/20/2012 05:24 AM, Dominique Belhachemi wrote:
> Hi Marco,
Hi Dominique,
>
> The current Debian sources for CTK are here:
> http://anonscm.debian.org/viewvc/debian-med/trunk/packages/ctk/trunk/debian/
>
Thanks, I put that link on our CTK Debian Wiki page.
> I merged a few of your changes into the trunk. Unfortunately I am still
> running into compilation issues when specifying
> -DCTK_LIB_DICOM/Core:BOOL=ON
>
> In file included from /usr/include/dcmtk/ofstd/ofstring.h:65:0,
> from /usr/include/dcmtk/oflog/tstring.h:27,
> from /usr/include/dcmtk/oflog/streams.h:27,
> from /usr/include/dcmtk/oflog/loglevel.h:29,
> from /usr/include/dcmtk/oflog/logger.h:28,
> from /usr/include/dcmtk/oflog/oflog.h:35,
> from /usr/include/dcmtk/dcmdata/dctypes.h:34,
> from /usr/include/dcmtk/dcmdata/dcbytstr.h:35,
> from /usr/include/dcmtk/dcmdata/dcchrstr.h:48,
> from /usr/include/dcmtk/dcmdata/dcvrpn.h:35,
> from
> /tmp/ctk/trunk/ctk-0.1.0~git20121219/Libs/DICOM/Core/ctkDICOMModel.cpp:33:
> /usr/include/dcmtk/ofstd/ofstream.h:67:22: fatal error: iostream.h: No
> such file or directory
>
> I am using an older dcmtk (3.6.0-9), will try with a newer version soon.
>
This is the fix, it is actually a workaround for a debian bug in
libdcmtk2-dev (#637687):
https://github.com/nolden/CTK/commit/f8a38a141a4d3dc1bf8ef5a95a8b3da1def7bfb1
The other one that is not included in CTK and won't be is:
https://github.com/nolden/CTK/commit/6946f75a100ce0950226779e71bed34dce624599
> I also believe that the current github version contains your changes
> already. Your patch debian/patches/backport-of-dcmscu-from-dcmtk-3.6.1
> doesn't apply cleanly and can probably removed.
>
> Any idea when CTK is using a plain pythonqt version? I would like to
> turn on another option as well.
> -DCTK_LIB_Scripting/Python/Core:BOOL=ON
>
JC is working on that and already submitted most patches to upstream. We
somewhat agreed that for a first version of a CTK debian package we
could leave it OFF and turn it on later. Also it could make sense to
split the CTK package at some point into ctk, ctk-pluginfw, ctk-widgets etc.
> Cheers
> -Dominique
>
Best
Marco
>
> On Wed, Dec 19, 2012 at 1:13 PM, Nolden, Marco
> <M.Nolden at dkfz-heidelberg.de <mailto:M.Nolden at dkfz-heidelberg.de>> wrote:
>
> Hi Dominique,____
>
> __ __
>
> Sounds great, thanks. CTK’s super build currently uses an unpatched
> 5.10.0, so I guess it works. The config is here: ____
>
> __ __
>
> https://github.com/commontk/CTK/blob/master/CMakeExternals/VTK.cmake____
>
> __ __
>
> For my tests in Bologna I used the VTK 5.8 that’s currently included
> in Debian sid.____
>
> __ __
>
> I do not have much experience with debian packaging, so in my github
> the most useful addition is probably the version number generation
> code. I read a bit about git-based packaging but too many things
> were new to me. Do you think it would make sense to work on the
> package itself on github or is there an official debian location for
> that?____
>
> __ __
>
> Best____
>
> Marco____
>
> __ __
>
> __ __
>
> __ __
>
> __ __
>
> *Von:*Dominique Belhachemi [mailto:domibel.dd at gmail.com]
> *Gesendet:* Mittwoch, 19. Dezember 2012 16:00
> *An:* Nolden, Marco
> *Cc:* ctk-developers at commontk.org <mailto:ctk-developers at commontk.org>
> *Betreff:* Re: [Ctk-developers] CTK, DCMTK and Debian____
>
> __ __
>
> Hi Marco,____
>
> I can help with updating VTK+CTK in Debian Experimental. Does the
> current CTK work with an unpatched VTK 5.10?____
>
> Thanks____
>
> -Dominique____
>
> __ __
>
> On Wed, Dec 19, 2012 at 3:23 AM, Nolden, Marco
> <M.Nolden at dkfz-heidelberg.de <mailto:M.Nolden at dkfz-heidelberg.de>>
> wrote:____
>
> Hi,
>
> during the Bologna hackfest I succeeded (with the help of Michael!)
> to build CTK again with a plain DCMTK 3.6.0 and also fixed
> compatibility with Debian's VTK 5.8. I created a summary page of
> the status on the wiki:
> http://www.commontk.org/index.php/Debian_Packaging . Maybe other
> people who did some work in that area could add some comments or
> useful links.
>
> Best
> Marco
>
>
> -----Ursprüngliche Nachricht-----
> Von: ctk-developers-bounces at commontk.org
> <mailto:ctk-developers-bounces at commontk.org>
> [mailto:ctk-developers-bounces at commontk.org
> <mailto:ctk-developers-bounces at commontk.org>] Im Auftrag von Nolden,
> Marco
> Gesendet: Dienstag, 11. Dezember 2012 17:03
> An: Michael Onken; ctk-developers at commontk.org
> <mailto:ctk-developers at commontk.org>
> Cc: dicom at offis.de <mailto:dicom at offis.de>____
>
> Betreff: Re: [Ctk-developers] CTK, DCMTK and Debian
>
> Hi Michael,
>
> I'm currently at the hackfest in Bologna and can further investigate
> your suggestion. I tried to integrate a recent scu.cc in CTK: there
> are a lot of compile errors related to changes in the logging or
> error constants on the DCMTK side:
>
> https://github.com/nolden/ctk-debian/issues/1
>
> Any chance to back port also the required stuff or should we just
> use an older scu?
>
> Best,
> Marco
>
>
> -----Ursprüngliche Nachricht-----
> Von: ctk-developers-bounces at commontk.org
> <mailto:ctk-developers-bounces at commontk.org>
> [mailto:ctk-developers-bounces at commontk.org
> <mailto:ctk-developers-bounces at commontk.org>] Im Auftrag von Michael
> Onken
> Gesendet: Dienstag, 30. Oktober 2012 12:53
> An: ctk-developers at commontk.org <mailto:ctk-developers at commontk.org>
> Betreff: Re: [Ctk-developers] CTK, DCMTK and Debian
>
> Hi Marco,
>
> On 25.10.2012 17:16, Marco Nolden wrote:
>
> > 2. DCMTK in debian is version 3.6.0. This unfortunately lacks the SCU
> > functionality we're using for Query/Retrieve. Before switching to
> > 3.6.1 in the superbuild we had a backported version of the new SCU
> > class in the CTK repository (ctkDcmSCU). I tried to reactivate this
> > backport in my modified package but it failed to compile. I think the
> > best way for this would be to fix this in CTK itself by putting the
> > new SCU class there again, make it compile and add some CMake logic
> > based on the DCMTK version to choose the right class. But I'm not
> sure
> > which other non-compatible changes we have that require DCMTK >=
> > 3.6.1.
>
> To my knowledge (which may be outdated) no new source code
> functionality besides DcmSCU enhancements are used in CTK.
>
> I would try to copy any recent DcmSCU.h/cc, rename the files (and
> classes) to CtkSCU.h/cc and use them in the CTK code instead. Then
> look how far you can get with that.
>
> However, there may have been changes in the BUILD infrastructure
> that you rely on but I do not have an overview what is used at the
> moment, or whether it is highly relevant for Debian builds.
>
> Best,
> Michael
>
> --
> Dipl.-Inform. Michael Onken
> FuE Bereich Gesundheit | R&D Division Health
>
> OFFIS
> FuE Bereich Gesundheit | R&D Division Health Escherweg 2 - 26121
> Oldenburg - Germany
> Phone/Fax.: +49 441 9722-149/111 <tel:%2B49%20441%209722-149%2F111>
> E-Mail: onken at offis.de <mailto:onken at offis.de>
> URL: http://www.offis.de
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
> _______________________________________________
> Ctk-developers mailing list
> Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
> http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers____
>
> __ __
>
>
--
----------------------------------------------------------------------
Dipl.-Inform. Med. Marco Nolden
Deutsches Krebsforschungszentrum (German Cancer Research Center)
Div. Medical & Biological Informatics Tel: (+49) 6221-42 2325
Im Neuenheimer Feld 280 Fax: (+49) 6221-42 2345
D-69120 Heidelberg eMail: M.Nolden at dkfz.de
More information about the Ctk-developers
mailing list