[Ctk-developers] Build system changes concerning include path handling

[Sascha Zelzer]

  Hi Jc,

sorry, I already pushed the commits to master. The changes are 
essentially what we discussed during the hackfest. I just now branched 
of from the last commit before the relevant changes and cherry-picked 
them into the branch, so you can have a better look:

http://github.com/saschazelzer/CTK/tree/include_deps

- Basically, I create a third input file for the "DGraph" Utility called 
"DGraphInput-alldep-withext.txt" containing the whole dependency 
information including external projects.
- In ctkMacroValidateBuildOptions, for each CTK sub-project (App, Lib, 
Plugin) a variable named ${project_name}_DEPENDENCIES is set to contain 
a list of project names on which ${project_name} depends on (including 
external projects).
- The CMake files in the folder "CMakeExternals" have been modified such 
that they set two variables, containing a list of include directories 
(or variable names pointing to include directories, which are set by a 
find_package call) and the argument to the find_package command
- The toplevel CMakeLists.txt file now calls "find_package" for all 
enabled external projects (if the corresponding variable containing the 
find_package argument is set), instead of the libraries/plugins 
themselves. This way, all the variables pointing to specific include 
directories of external projects are set before the invocation of the 
ctkMacroCreate* macros.
- The ctkMacroCreate* macros loop over the ${project_name}_DEPENDENCIES 
list and add only those to the current projects include paths.

If you find that something is broken, I will try to fix it ASAP.

Best,
Sascha

On 10/15/2010 07:53 PM, Jean-Christophe Fillion-Robin wrote:
> Hi Sasha,
>
> Sounds great !
>
> Could you publish your changes to a branch on your fork: 
> http://github.com/saschazelzer/CTK ?
>
> Would be great to have a look :)
>
> Thks
> Jc
>
> On Fri, Oct 15, 2010 at 10:31 AM, Sascha Zelzer 
> <s.zelzer at dkfz-heidelberg.de <mailto:s.zelzer at dkfz-heidelberg.de>> wrote:
>
>      Hi Folks,
>
>     I plan to push the build-system changes I worked on during the
>     Barcelona hackfest to CTK/master later on this day. As a reminder,
>     the changes improve the handling of include path dependencies such
>     that every Lib/App/Plugin sees only the include dirs from its
>     dependencies, instead of the "everybody sees everything" approach.
>     Also inheriting the include dirs from external dependencies (on
>     which a lib could depend through another dependency transitively)
>     is now handled properly.
>
>     Although I hope that the transition will be smooth and
>     transparent, please send me an email if you are running into
>     include path or linking errors after updating your repository
>     (please try a clean rebuild first).
>
>     Thanks,
>     Sascha
>     _______________________________________________
>     Ctk-developers mailing list
>     Ctk-developers at commontk.org <mailto:Ctk-developers at commontk.org>
>     http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers
>
>
>
>
> -- 
> Phone: 1-518-836-2174
> Ext: 304

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/ctk-developers/attachments/20101015/0afae2e6/attachment.htm>