<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<title></title>
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Jc,<br>
<br>
sorry, I already pushed the commits to master. The changes are
essentially what we discussed during the hackfest. I just now
branched of from the last commit before the relevant changes and
cherry-picked them into the branch, so you can have a better look:<br>
<br>
<a class="moz-txt-link-freetext" href="http://github.com/saschazelzer/CTK/tree/include_deps">http://github.com/saschazelzer/CTK/tree/include_deps</a><br>
<br>
- Basically, I create a third input file for the "DGraph" Utility
called "DGraphInput-alldep-withext.txt" containing the whole
dependency information including external projects.<br>
- In ctkMacroValidateBuildOptions, for each CTK sub-project (App,
Lib, Plugin) a variable named ${project_name}_DEPENDENCIES is set to
contain a list of project names on which ${project_name} depends on
(including external projects).<br>
- The CMake files in the folder "CMakeExternals" have been modified
such that they set two variables, containing a list of include
directories (or variable names pointing to include directories,
which are set by a find_package call) and the argument to the
find_package command<br>
- The toplevel CMakeLists.txt file now calls "find_package" for all
enabled external projects (if the corresponding variable containing
the find_package argument is set), instead of the libraries/plugins
themselves. This way, all the variables pointing to specific include
directories of external projects are set before the invocation of
the ctkMacroCreate* macros.<br>
- The ctkMacroCreate* macros loop over the
${project_name}_DEPENDENCIES list and add only those to the current
projects include paths.<br>
<br>
If you find that something is broken, I will try to fix it ASAP.<br>
<br>
Best,<br>
Sascha<br>
<br>
On 10/15/2010 07:53 PM, Jean-Christophe Fillion-Robin wrote:
<blockquote
cite="mid:AANLkTikSQ3uFH7pwwDUZnAHyNsEwCdEog-OOagwqR7W-@mail.gmail.com"
type="cite">Hi Sasha, <br>
<br>
Sounds great ! <br>
<br>
Could you publish your changes to a branch on your fork: <a
moz-do-not-send="true" href="http://github.com/saschazelzer/CTK">http://github.com/saschazelzer/CTK</a>
?<br>
<br>
Would be great to have a look :) <br>
<br>
Thks<br>
Jc<br>
<br>
<div class="gmail_quote">On Fri, Oct 15, 2010 at 10:31 AM, Sascha
Zelzer <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:s.zelzer@dkfz-heidelberg.de">s.zelzer@dkfz-heidelberg.de</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
Hi Folks,<br>
<br>
I plan to push the build-system changes I worked on during the
Barcelona hackfest to CTK/master later on this day. As a
reminder, the changes improve the handling of include path
dependencies such that every Lib/App/Plugin sees only the
include dirs from its dependencies, instead of the "everybody
sees everything" approach. Also inheriting the include dirs
from external dependencies (on which a lib could depend
through another dependency transitively) is now handled
properly.<br>
<br>
Although I hope that the transition will be smooth and
transparent, please send me an email if you are running into
include path or linking errors after updating your repository
(please try a clean rebuild first).<br>
<br>
Thanks,<br>
Sascha<br>
_______________________________________________<br>
Ctk-developers mailing list<br>
<a moz-do-not-send="true"
href="mailto:Ctk-developers@commontk.org" target="_blank">Ctk-developers@commontk.org</a><br>
<a moz-do-not-send="true"
href="http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers"
target="_blank">http://public.kitware.com/cgi-bin/mailman/listinfo/ctk-developers</a><br>
</blockquote>
</div>
<br>
<br clear="all">
<br>
-- <br>
Phone: 1-518-836-2174<br>
Ext: 304<br>
</blockquote>
<br>
</body>
</html>