[ITK] Tests with multi-file input data (Bruker2DSEQ)

[Wood, Tobias]

Hello,

Sorry for the delay, I’ve pushed my changes to Gerrit. One of the bugs turned out not to be a bug at all - we were acquiring some data wrong. The other bug appears to be not in the Bruker code but somewhere else, I’m still chasing.

I added everyone on this thread as a reviewer except Dženan, as he didn’t show up in Gerrit. Interestingly, the original author (Don Bigler), did show up as a reviewer when I was looking for Dženan, so I added him in case he is still contributing!

I’m sure there are some parts of this code that could be improved, so I’m expecting a bit of criticism. In particular, for reading the JCAMP-DX header format I took a “whatever works” approach, as if there is a clean way to read it I don’t see it.

Best wishes,
Toby

On 14/06/2017, 19:24, "Jon Haitz Legarreta" <jhlegarreta at vicomtech.org<mailto:jhlegarreta at vicomtech.org>> wrote:

Hi Tobias,
this is already a huge step in the right direction !

As for the question
For my uses, I think the best approach would be to consider 2dseq + visu_pars the minimum, but if the other headers are present read them in to get the meta-data. Is that acceptable?

Seems reasonable. You will surely have a better grasp of the format than many of us by now !

Let us know if you encounter further problems, or whether you need help solving the issues.

Thanks for the effort.
JON HAITZ



--

On 14 June 2017 at 16:25, Wood, Tobias <tobias.wood at kcl.ac.uk<mailto:tobias.wood at kcl.ac.uk>> wrote:
Thanks Brad, Matt and Dženan - the ITKData target is the crucial one, which also gets picked up by ITKIOBruker2DSEQ-all.

The basic test runs and passes now. Back to polishing - I have two bugs, one minor and one a bit more important - that I will try to fix before submitting properly.

Best wishes,
Toby

_______________________________________________
Community mailing list
Community at itk.org<mailto:Community at itk.org>
http://public.kitware.com/mailman/listinfo/community<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpublic.kitware.com%2Fmailman%2Flistinfo%2Fcommunity&data=01%7C01%7Ctobias.wood%40kcl.ac.uk%7C6f0a50e7ce374420dcfd08d4b352bcc1%7C8370cf1416f34c16b83c724071654356%7C0&sdata=NDaR5y5Pd43bHnIg3jFqYkmOTnehZli%2By0Gg1eH2wlk%3D&reserved=0>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://public.kitware.com/pipermail/community/attachments/20170707/be90f00c/attachment.html>