<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Title" content="">
<meta name="Keywords" content="">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Courier New";
panose-1:2 7 3 9 2 2 5 2 4 4;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"Avenir Next";
panose-1:2 11 5 3 2 2 2 2 2 4;}
@font-face
{font-family:PMingLiU;
panose-1:2 2 5 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Courier;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Avenir Next";
color:windowtext;
font-weight:normal;
font-style:normal;
text-decoration:none none;}
span.msoIns
{mso-style-type:export-only;
mso-style-name:"";
text-decoration:underline;
color:teal;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:595.0pt 842.0pt;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body bgcolor="white" lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-family:"Avenir Next"">Hello,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next"">Sorry for the delay, I’ve pushed my changes to Gerrit. One of the bugs turned out not to be a bug at all - we were acquiring some data wrong. The other bug appears to be not in the Bruker code but
somewhere else, I’m still chasing.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next"">I added everyone on this thread as a reviewer except Dženan, as he didn’t show up in Gerrit. Interestingly, the original author (Don Bigler), did show up as a reviewer when I was looking for Dženan,
so I added him in case he is still contributing!<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next"">I’m sure there are some parts of this code that could be improved, so I’m expecting a bit of criticism. In particular, for reading the JCAMP-DX header format I took a “whatever works” approach, as
if there is a clean way to read it I don’t see it.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next"">Best wishes,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next"">Toby<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-family:"Avenir Next""><o:p> </o:p></span></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in">On 14/06/2017, 19:24, "Jon Haitz Legarreta" <<a href="mailto:jhlegarreta@vicomtech.org">jhlegarreta@vicomtech.org</a>> wrote:<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in">
Hi Tobias,<br>
this is already a huge step in the right direction !<br>
<br>
As for the question<br>
<i>For my uses, I think the best approach would be to consider 2dseq + visu_pars the minimum, but if the other headers are present read them in to get the meta-data. Is that acceptable?</i><br>
<br>
Seems reasonable. You will surely have a better grasp of the format than many of us by now !<br>
<br>
Let us know if you encounter further problems, or whether you need help solving the issues.<br>
<br>
Thanks for the effort.<br>
JON HAITZ<o:p></o:p></p>
<div>
<p class="MsoNormal" style="margin-left:.5in"><br clear="all">
<o:p></o:p></p>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div>
<div align="center">
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0">
<tbody>
<tr>
<td style="padding:0in 0in 0in 0in"></td>
</tr>
</tbody>
</table>
</div>
<pre style="mso-margin-top-alt:0in;margin-right:0in;margin-bottom:12.0pt;margin-left:.5in;word-wrap:break-word;white-space:pre-wrap"><span style="color:black">--<o:p></o:p></span></pre>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-left:.5in">On 14 June 2017 at 16:25, Wood, Tobias <<a href="mailto:tobias.wood@kcl.ac.uk" target="_blank">tobias.wood@kcl.ac.uk</a>> wrote:<o:p></o:p></p>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal" style="margin-left:.5in">Thanks Brad, Matt and Dženan - the ITKData target is the crucial one, which also gets picked up by ITKIOBruker2DSEQ-all.<span style="font-family:PMingLiU"><br>
<br>
</span>The basic test runs and passes now. Back to polishing - I have two bugs, one minor and one a bit more important - that I will try to fix before submitting properly.<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal" style="margin-left:.5in"><br>
Best wishes,<br>
Toby<br>
<br>
_______________________________________________<br>
Community mailing list<br>
<a href="mailto:Community@itk.org">Community@itk.org</a><br>
<a href="https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpublic.kitware.com%2Fmailman%2Flistinfo%2Fcommunity&data=01%7C01%7Ctobias.wood%40kcl.ac.uk%7C6f0a50e7ce374420dcfd08d4b352bcc1%7C8370cf1416f34c16b83c724071654356%7C0&sdata=NDaR5y5Pd43bHnIg3jFqYkmOTnehZli%2By0Gg1eH2wlk%3D&reserved=0" target="_blank">http://public.kitware.com/mailman/listinfo/community</a><o:p></o:p></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal" style="margin-left:.5in"><o:p> </o:p></p>
</div>
</div>
</div>
</body>
</html>