[ITK Community] [Insight-users] Bug in itkDCMTKFileReader.cxx

[Johnson, Hans J]

http://review.source.kitware.com/#/c/14186/



-----Original Message-----
From: Matt McCormick <matt.mccormick at kitware.com>
Date: Tuesday, January 28, 2014 3:22 PM
To: Richard Frank <rfrank at dominionsw.com>
Cc: "insight-users at itk.org" <insight-users at itk.org>
Subject: Re: [Insight-users] [ITK Community]  Bug in itkDCMTKFileReader.cxx

Hi Rick,

Could a patch please be submitted [1]?

Thanks,
Matt

[1]
http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftware
Process/SubmitAPatchToGerrit/index.html

On Tue, Jan 28, 2014 at 4:20 PM, Richard Frank <rfrank at dominionsw.com>
wrote:
>
>
> I notice the following code:
>
> 1.  int
> 2.  DCMTKFileReader
> 3.  ::GetSlopeIntercept(double &slope, double &intercept)
> 4.  {
> 5.  if(this->GetElementDS<double>(0x0028,1053,1,&slope,false) !=
>EXIT_SUCCESS)
> 6.  {
> 7.  slope = 1.0;
> 8.  }
> 9.  if(this->GetElementDS<double>(0x0028,1052,1,&intercept,false) !=
>EXIT_SUCCESS)
> 10. {
> 11. intercept = 0.0;
> 12. }
> 13. return EXIT_SUCCESS;
> 14. }
>
>
> Notice that the element numbers 1053, 1052 are not specified as hex.
>
> I believe this is incorrect.
>
> Rick
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users
> _______________________________________________
> Community mailing list
> Community at itk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/community
_____________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://www.kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-users



________________________________
Notice: This UI Health Care e-mail (including attachments) is covered by the Electronic Communications Privacy Act, 18 U.S.C. 2510-2521, is confidential and may be legally privileged.  If you are not the intended recipient, you are hereby notified that any retention, dissemination, distribution, or copying of this communication is strictly prohibited.  Please reply to the sender that you have received the message in error, then delete it.  Thank you.
________________________________
_____________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://www.kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-users