[ITK Community] [Insight-users] Bug in itkDCMTKFileReader.cxx

Matt McCormick matt.mccormick at kitware.com
Tue Jan 28 16:22:19 EST 2014


Hi Rick,

Could a patch please be submitted [1]?

Thanks,
Matt

[1] http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html

On Tue, Jan 28, 2014 at 4:20 PM, Richard Frank <rfrank at dominionsw.com> wrote:
>
>
> I notice the following code:
>
> 1.  int
> 2.  DCMTKFileReader
> 3.  ::GetSlopeIntercept(double &slope, double &intercept)
> 4.  {
> 5.  if(this->GetElementDS<double>(0x0028,1053,1,&slope,false) != EXIT_SUCCESS)
> 6.  {
> 7.  slope = 1.0;
> 8.  }
> 9.  if(this->GetElementDS<double>(0x0028,1052,1,&intercept,false) != EXIT_SUCCESS)
> 10. {
> 11. intercept = 0.0;
> 12. }
> 13. return EXIT_SUCCESS;
> 14. }
>
>
> Notice that the element numbers 1053, 1052 are not specified as hex.
>
> I believe this is incorrect.
>
> Rick
> _____________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Kitware offers ITK Training Courses, for more information visit:
> http://www.kitware.com/products/protraining.php
>
> Please keep messages on-topic and check the ITK FAQ at:
> http://www.itk.org/Wiki/ITK_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.itk.org/mailman/listinfo/insight-users
> _______________________________________________
> Community mailing list
> Community at itk.org
> http://public.kitware.com/cgi-bin/mailman/listinfo/community
_____________________________________
Powered by www.kitware.com

Visit other Kitware open-source projects at
http://www.kitware.com/opensource/opensource.html

Kitware offers ITK Training Courses, for more information visit:
http://www.kitware.com/products/protraining.php

Please keep messages on-topic and check the ITK FAQ at:
http://www.itk.org/Wiki/ITK_FAQ

Follow this link to subscribe/unsubscribe:
http://www.itk.org/mailman/listinfo/insight-users



More information about the Community mailing list