[CMake] Kitware Robot left some block-end command arguments

Marcin Wojdyr wojdyr at gmail.com
Wed Aug 15 12:05:11 EDT 2012


OK

I don't know how you usually exchange patches, i'm attaching a patch
made by git format-patch

Not tested

M

On 15 August 2012 16:30, David Cole <david.cole at kitware.com> wrote:
> Yes... the script only did one-line occurrences. If you'd like to submit a
> hand-made patch to remove the rest, we'd take it...
>
>   :-)
>
>
> On Wed, Aug 15, 2012 at 11:27 AM, Marcin Wojdyr <wojdyr at gmail.com> wrote:
>>
>> I was looking into git history of one file and just noticed this:
>>
>> commit 9db3116226cb99fcf54e936c833953abcde9b729
>> Author: Kitware Robot <kwrobot at kitware.com>
>> Date:   Mon Aug 13 13:50:14 2012 -0400
>>
>>     Remove CMake-language block-end command arguments
>>
>>
>> fyi: the script only removed single-line arguments.
>> A few multiline args are left, e.g.:
>>
>> [wojdyr at dt Modules]$ grep -rP 'endif *\([^)]' .
>> ./FindGTK.cmake:  endif(GTK_gtk_INCLUDE_PATH
>> ./CMakeDetermineCXXCompiler.cmake:endif (CMAKE_CROSSCOMPILING
>> ./CMakeFindBinUtils.cmake:endif("${CMAKE_CXX_COMPILER_ID}" MATCHES "MSVC"
>> ./CMakeDetermineCCompiler.cmake:endif (CMAKE_CROSSCOMPILING
>>
>>
>> Marcin
>> --
>>
>> Powered by www.kitware.com
>>
>> Visit other Kitware open-source projects at
>> http://www.kitware.com/opensource/opensource.html
>>
>> Please keep messages on-topic and check the CMake FAQ at:
>> http://www.cmake.org/Wiki/CMake_FAQ
>>
>> Follow this link to subscribe/unsubscribe:
>> http://www.cmake.org/mailman/listinfo/cmake
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Remove-CMake-multiline-block-end-command-arguments.patch
Type: application/octet-stream
Size: 8284 bytes
Desc: not available
URL: <http://www.cmake.org/pipermail/cmake/attachments/20120815/56a171b8/attachment.obj>


More information about the CMake mailing list