[CMake] Patch for FindBoost.cmake

Joseph Garvin joseph.h.garvin at gmail.com
Wed Sep 9 10:37:30 EDT 2009


I must have specified the order of files backwards when I made the patch,
the issue is that *currently* in 2.6.4, 2 hyphens happen, my patch is meant
to remove hyphens. Looking at trunk though it appears the problem was
already found.

On Tue, Sep 8, 2009 at 3:34 PM, Andreas Pakulat <apaku at gmx.de> wrote:

> On 08.09.09 13:47:56, Joseph Garvin wrote:
> > Without this patch FindBoost.cmake will look for the wrong filenames
> > when linking against a release build of boost. For debug it looks for
> > the correct names, but for release it adds spurious hyphens. It looks
> > like the hyphens used to be necessary, then the code changed and
> > someone changed debug to match to the change but forgot to update
> > release.
> >
> > I'd love to see this in 2.6.5 so I don't have to ship a
> > FindBoost.cmake replacement with my app :P
>
> I don't see why this patch would be necessary. The
> boost_(MULTITHREAD|STATIC|ABI|COMPILER) variables already start with a
> hyphen, so your patch will add 2 hyphens to the names that are being
> searched.
>
> There's a difference between the debug and the release find_library
> calls, but thats just adding _boost_ABI_TAG in the debug-case.
>
> This is with CMake from the 2.6 branch
>
> Andreas
>
> --
> It may or may not be worthwhile, but it still has to be done.
> _______________________________________________
> Powered by www.kitware.com
>
> Visit other Kitware open-source projects at
> http://www.kitware.com/opensource/opensource.html
>
> Please keep messages on-topic and check the CMake FAQ at:
> http://www.cmake.org/Wiki/CMake_FAQ
>
> Follow this link to subscribe/unsubscribe:
> http://www.cmake.org/mailman/listinfo/cmake
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.cmake.org/pipermail/cmake/attachments/20090909/eab66e8f/attachment-0001.htm>


More information about the CMake mailing list